Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965243AbeAJOXf (ORCPT + 1 other); Wed, 10 Jan 2018 09:23:35 -0500 Received: from mail-bl2nam02on0041.outbound.protection.outlook.com ([104.47.38.41]:57466 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751293AbeAJOXd (ORCPT ); Wed, 10 Jan 2018 09:23:33 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Thomas.Lendacky@amd.com; Subject: Re: [PATCH v3 3/3] x86/retpoline: Convert generic specific retpolines to use RETPOLINE_GENERIC To: "Woodhouse, David" , "tglx@linutronix.de" , "andi@firstfloor.org" Cc: "linux-kernel@vger.kernel.org" , "peterz@infradead.org" , "tim.c.chen@linux.intel.com" , "torvalds@linux-foundation.org" , "ak@linux.intel.com" , "x86@kernel.org" , "pjt@google.com" , "luto@kernel.org" , "dave.hansen@intel.com" , "jikos@kernel.org" , "gregkh@linux-foundation.org" References: <20180110022831.29826-1-andi@firstfloor.org> <20180110022831.29826-4-andi@firstfloor.org> <1515590133.22302.148.camel@amazon.co.uk> From: Tom Lendacky Message-ID: Date: Wed, 10 Jan 2018 08:23:25 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1515590133.22302.148.camel@amazon.co.uk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.78.1] X-ClientProxiedBy: DM5PR1101CA0017.namprd11.prod.outlook.com (10.174.246.27) To MWHPR12MB1152.namprd12.prod.outlook.com (10.169.204.16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f19ab9de-686c-40fa-0c07-08d55835b890 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603307)(7153060)(7193020);SRVR:MWHPR12MB1152; X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1152;3:+of3qdy0GAPiT2pjTHJuZx7VwWjdoeTPVY2r/4C1fzWjUx1YvVXQD6Fmx2pr/MJX7zQunA5Rwm2J/DSm6D38G2zY+RjM/Qtv2rHXv8pnIe9LqtK+IrQdDNHIqhnZ7I4fO7CV4UuusCAZncsVMq+8xeQ9eusSg7dG06dBzgovE+HtjSOGTEBBKxS4YzZwBBKBrpDNHlLuKJmuIrUGoyJ55RE2elJMbgYFuWeZDl/20+K47RJdv98G5r3qHg1zS8aQ;25:59vrkz12507EfBaoukGNMuXxcaepsyqa0imL7/OoOuZl63mhzv7X1G/tZxtZSOMFJN03kGSwrl9MPoxm+CnytBZxrzLGwCroP+COFi8ibUMwAMK7NVUKI5BeBqh1IyZjKZzXeJ57y1g0l+mvcC8OKQYOBd4xLstWMyilb2pVs6EvSWoekw+JGhrl5l8rQ94WpuLaaKSiUnlPvl4wPOLFDC2XoQ7sjX/+BFg3j8q+aqwRg5w7iFPK+hinPKpPh46aOiimsJuw64ktjplaQ+AwUnqt23c8CctAFt2WTunlrlxsH6lBT0dZcqM6IrHh/Ij/BU+F6AVoNnF6V2enjfADcA==;31:u8Hzf2fS/twsJXVZv5R0Ratozykl0ecN4SribZ3NEpydTFuIvcsQuvpBLIy+6LUAZaCCJefnI7aiVRl0eIsW9pdEhHG8EB0fCXoje/9Jbho5mkEhEprRP2TieQNQxG0vtGCPuucBwv02w1PwK1KAVw7ZDhzreMyVni9z+hIDC0j0ugWNySWPuNn5oIo6XSISNxqnD+exH/P1J9FnmPmBdmFRi3vWbqTqbEawvoIQYQs= X-MS-TrafficTypeDiagnostic: MWHPR12MB1152: X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1152;20:b37vNzYvNhCSvEmsIjeXEPdh7cHvgendUQOAD3B6heeLTSFmlHPEnRO/tSrgTzsVarKT1fhSrd9CtE71ve22hTJAWTdwbKgdziajy4nBubmw4kbdpRIu5XXCOKsKrUeGn2KeS0UqvPoZ2jmZ0o8LplqZQUrV3pm6dtl3hGxOdY1Lattkto3el2d8xW/4eJUWB7DhZSecmKf/X12WQDKa8gULEZxM3taXkLK1yMTLQdqnGeytpOGY7PL5LDNbdnb4LMoUZAgXDWEvAj1czLbZGt2ecX+GC2TiDO/obcl0XQyDOz4iK3p0AUPbiBC06rgwbaM+jipC0whBpw/1TQo7XezdWiR5yU37K2W/SytTJeuN7dsA7DFyY3iuPDilGI6YSaLINRuEGt7FSrYiRS32psxWxyOKBZNVwaxE0V57ryjKLmB8M2G5NZ3g+QQYGEE3WUTY/3KBmy8gWkewr7FV+GQ3BNuJhy9Lahwu99EXQICcNrhSq4gNHmxkaJIRmlMU;4:DiKFY9wmCsdJvwp0Dt/I9nuONOx+utgNKWfFP9KN30d/+U+ffhXoeq12L1wjVptE4AXABt/lu7WtCjTMLbvVMNHGZT4gZLdm34ezm+SEIv7SsQYoPfAd5cjR8/zEXMr5lPic3FmN/Y9HY4Vt8Gb/dImv8xwG+rn2VlCvjdNQ9+Fijfq3hbP8SZN5IkG/Z9NG63Y51CpsKJ5XZ9N8Cl+lNh1mH0e2EKTyg2XkWMXq1PXkcDk1KJED8RU9ubjVmXw+2HfwTu/aMvhvvUv89eYHElsSivt7SoPVjz3rhgMIjQ8yteFM+vY7XuC3SuXrV/4M X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(3231023)(944501075)(10201501046)(6055026)(6041268)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(20161123562045)(6072148)(201708071742011);SRVR:MWHPR12MB1152;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:MWHPR12MB1152; X-Forefront-PRVS: 0548586081 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(396003)(346002)(376002)(366004)(39860400002)(39380400002)(377424004)(189003)(24454002)(199004)(53546011)(58126008)(6246003)(316002)(53936002)(4326008)(110136005)(83506002)(2906002)(54906003)(25786009)(3260700006)(16526018)(106356001)(16576012)(50466002)(5660300001)(230700001)(52146003)(2486003)(23676004)(76176011)(52116002)(65826007)(105586002)(8676002)(81166006)(6666003)(8936002)(6486002)(77096006)(90366009)(229853002)(47776003)(65956001)(2950100002)(64126003)(31696002)(86362001)(31686004)(7416002)(2501003)(68736007)(66066001)(65806001)(97736004)(305945005)(7736002)(72206003)(36756003)(478600001)(386003)(81156014)(3846002)(6116002)(2201001)(41533002);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR12MB1152;H:[10.236.65.116];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjEyTUIxMTUyOzIzOk4yMVhBTmtKT0JNb3JnSW1OM3dFK1Q3OXBE?= =?utf-8?B?Nk5meTVqZjR1Y1ZQZmREakk2K1d0d2hUS1F3a2NkR3BMQ3lrUVFFa1dZejY1?= =?utf-8?B?bVhrYitHM1JZOE82czQ3ZkxBb3VQMkZDL1k3YkJTSkozdVE0ajNvRXFaNTZG?= =?utf-8?B?YlFLRndwSTVxaGRIWFVZbEdWc0dFM0RNdnZwVm9PaFI2VFB2RThoY0EvcUhG?= =?utf-8?B?aFBsSzA1eG5rMVlqazQ4clFzV1dwWDV6Q3NZQ3lIclVQRFBOWE82SzlHQkdZ?= =?utf-8?B?Sm5KZGw3d1FrMEpFUDBiNVhoOEVvN2RqTDNzalFPREtCTFpIVmRINkNjT2tU?= =?utf-8?B?VTRpSjN6UlpGZmsya09rZGI0dFVBZGViK1g3RUpWbWc5aEFhSFR3ZnUyVmE3?= =?utf-8?B?WmFEZUFXdTVBVGNkd0hnSk9SR1VROUF6STEwWDQ5eVV6c1ZUQ1oxdkUyQzJw?= =?utf-8?B?cG1VVXRjaTZaU3pKYkliRVNEY2NQYm5ISkRjTXdOOW1DVnpBZlYzZjFvVnF4?= =?utf-8?B?a2FYampQbUNJSlFtZ2Fscm82N0hjMWJWZjNVdy82MFVSRVhYTXh3NktsMnJC?= =?utf-8?B?SVlaOFJpTFJIdHdCYzFLTk83VTlvSW02Q1V4UWlmZmdmNkVBdmZBMXFTYmF4?= =?utf-8?B?SFJ4UjQyclBpU2RUSDdWejRNRXkzMkFoTEJYbVRjdlROVGJwYlJpMWp3Tkhs?= =?utf-8?B?YUMraWg3L203b1FnWlhyZmx1aDhFeDFxZGFNYjhDMENZcExrSFhWZjZ5R2FE?= =?utf-8?B?VnZ1NmZES0ZxWVNTZUp1M2VlMzFOWjZyazlXUHdFMnBEN1docnlnbEdsMjRr?= =?utf-8?B?eGIrTUJTbytkZis1dnlkY2dwUStGV0ZtSi85VkpVeTF6Qk0yN0hGaGM3MVdX?= =?utf-8?B?QXpvelFqZGthd2R1dlc3cUlISlBRUDlSTWpvUnpwdXZ1U1FMQjZkMUVhQWVx?= =?utf-8?B?cTZtNzk5ZUdZMlJmTWtwRVFOWmhHU1U1Z1pTWU5iUld0WHRNMk5NOGljTE96?= =?utf-8?B?Y0xDNTFWQkRuTlgxaUgyTXJWUUN2SWtvRnhxR0g5MldIbXg0dGN1MnVTY01h?= =?utf-8?B?RHZ4d2N4QzNYTUp0bzlYMjk0OWl0bTM1WDJwMXF0OGFxWUJ4WXhQZ1FTZnQ0?= =?utf-8?B?OHR5MytKZ3Qvd0lZV3FmSmJJbklUbTQ2ZUNxQUI3akxaWnRvSnEvUTAvZkgr?= =?utf-8?B?Q2hwVFp0cFlDeHZkU3VJVGk3emQ5c1ppYmhYNDdMVE1pNjRpNmR6eUVwZWJW?= =?utf-8?B?NC9hdUZsU1VWYXpPVkRDOGc3QStDOFpkWVIyY2dERnJuOVAxYkdZNVhvTXFR?= =?utf-8?B?bFAxbzg1MG1LV2FqRUYxNXVneHZ1WFJzR2U1bTJneUtQWGdYcWNZc3FsSjhO?= =?utf-8?B?R3gwVG5udzJIc1NRalZwTGYxTDZhdU4ydWZkVDdkc0lUaHl2b3JpdWhGWE0r?= =?utf-8?B?cTVjcU5OalMrOTdJUVhVYlpJd252N3JabHA4c2hUVVdYdzhnOUo4RjRRTndm?= =?utf-8?B?V0JGcnF2bkd4blhjSzgybmgzMjRsZXNyUHR1YmE5WUVrMXhlYlNUN2J1RHRo?= =?utf-8?B?czEyek52QlExa0xSd0JqdXdNRG9vYVphZzNsazVWMEFGQW9KYlFpY2JKdGZQ?= =?utf-8?B?MFJjOHg5VGxoeXdDL0xWS0JlS2hkR1psWFNoQXc0QzEvK1JhM2g3bHh5UVZq?= =?utf-8?B?MFNsaS85eG1jcnNDTEZadGlYbjZqazVIL1Ryalo4VEUybjY5dVBVN0EzcWJG?= =?utf-8?B?WDFLbGdSSC9GRGhtclZmRnFGazJ2WVZJejdPMm1MUzh2ZEUvTEtLa3Btczg0?= =?utf-8?B?Q2hvTHAvWHhTY2NRWmZZcXowMHg3NDYwdVd0YzRLS0ZjaCsvTzdVQW1hYllj?= =?utf-8?B?RVJZWWpkV2JIbnVMSEJ2T2tFNU9PcTVYTUptdnBIOW9YRERmb3BFM1JMbDVP?= =?utf-8?B?QkNzYnVrWEoyN1dtejBNaWRzbWRXOHF0VHYzYW5rb0FNNW14Tm84RDZUWkJX?= =?utf-8?B?ZUVoS0VrTkxmQ2xUbFBDekN6eTZVeVJZaUJOQXVDTmEzbUphL0NZVnJNRE9y?= =?utf-8?B?TmlwRjRLdURJRjZmMTJQdVpaUnpZQjBSSkpDWm9FejNTQlFub3F3U2JZWW1l?= =?utf-8?B?Y0E9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1152;6:K2XJU5dsLUFCNBk1FLKPcaaIJjZqUdk709/jLv7Jaiio9uKdTVoDEBF4FPIXnHSiRXgdYnddFzBb4N+Xv8GKPH0qnuqCuVbUB9FmCZVQt5aYj/9GnVGLo1atOkUkVYtFkJnY31k7GTZN3DQq8rAqYkGsWz6lbqODFyCt7/XhttOYNrKxI1SOAx7Qir8A3njXd/A5VOj36R26P7rvidosA3yJDBCoAQKv4e3LHLnNBXQ07fDhW0b6m2aZQoJ27GdFPgxk+3DGLtt0Kt64jr9N6ij0mwoKf4tDWE8DwXd5V7URDULi/UrPyOjFebAqZ6cVdRFXeRUgexJjcj+2BJ3y47blfBN1XC8NdXFeYNdDn1g=;5:PvCv/SYBt3sEw7gUm082XWLibktqbJv7qhHMocMId0CAO5UPOQVpkmjddEaqSH00sc1+vZhyJg5xfCKyXUuXBsCPibf7YchudF8dtXEvv1no/zV2XqX31Pnhh6BBXVikZVgO92BDcSwIsDuyC2HjHqcvACys/oJPwZXlspyWKaU=;24:VAt+KFp93+DYG7BCSNuGWQw3C3lfZhsbJY9ISF4QEZPTBxcgH3TVu2bPBfBBwjez06tRLHFBYabPHB9Bq0w/S1MZggnCcSZZiTOkDn/Q9zk=;7:FdIrsNw95BEI70OdcUzoE32ZEJwSNB8OpY57WwxHLz7UH/oNxF8u5LQDb6ja+D04OfL3FtutUYB+PjBWlYk4dMCbXOxyINPqhZeVxJpMIP/21B5IQrE0LNuui/3XbohRQuuIoY3Z4MchODgSk4JEHl/AkBQhe54kBYYqwkKKufIOKIIFrV3wdwbdjgm3HKJIVPPM8XqoSAs1JFdROEacMZAZDCb9JsZnf/0c27VrlbUPFrZ1Y6fpa/RV61zqOG2s SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1152;20:6gaZDbRKY17fp5lrRpPQE/9EEvv7dzcbzWfHKb0EU5qkx6z3r9Y3yR+7DEkw957tSzTdJXenLkFag5fwfGmz6n8ZudDjnJKy3214IYnQmEMDXY+lWSEJ4GoKU6eUkOehwuXdQkITtC01iPArHCgjbH6/tTXEZsGn8lLGkgWUHOEMx081Sh/vF4X8bKQSWITngyBYAuLFDVsXruFXRg7Z498HXMQfXuFUQKoIOzFgOvv/nfBwcpeKfH1mOFcY9eq2 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2018 14:23:28.5129 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f19ab9de-686c-40fa-0c07-08d55835b890 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1152 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 1/10/2018 7:15 AM, Woodhouse, David wrote: > On Tue, 2018-01-09 at 18:28 -0800, Andi Kleen wrote: >> From: Andi Kleen >> >> X86_FEATURE_RETPOLINE has been renamed to X86_FEATURE_RETPOLINE_GENERIC. >> Convert the sequences using it. > > AMD documentation says they need the RSB fill too, so these should stay > under X86_FEATURE_RETPOLINE I think. AMD processors don't fall back to the indirect predictor on an underflow so this isn't needed on AMD if it is purely for underflow prevention. Thanks, Tom > > > > Amazon Web Services UK Limited. Registered in England and Wales with > registration number 08650665 and which has its registered office at 60 > Holborn Viaduct, London EC1A 2FD, United Kingdom.