Subject: Re: [RESEND PATCH V2 3/4] perf/x86/intel: drain PEBS buffer in event
 read
To: Jiri Olsa <jolsa@redhat.com>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
        linux-kernel@vger.kernel.org, tglx@linutronix.de,
        eranian@google.com, ak@linux.intel.com
References: <1515424516-143728-1-git-send-email-kan.liang@intel.com>
 <1515424516-143728-4-git-send-email-kan.liang@intel.com>
 <20180110103929.GB18942@krava>
From: "Liang, Kan" <kan.liang@linux.intel.com>
Message-ID: <6bb19af0-24e5-d711-cb6f-139eb99253c1@linux.intel.com>
Date: Wed, 10 Jan 2018 09:31:56 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <20180110103929.GB18942@krava>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org


On 1/10/2018 5:39 AM, Jiri Olsa wrote:
> On Mon, Jan 08, 2018 at 07:15:15AM -0800, kan.liang@intel.com wrote:
>> From: Kan Liang <kan.liang@linux.intel.com>
>>
>> When the PEBS interrupt threshold is larger than one, there is no way to
>> get exact auto-reload times and value needed for event update unless
>> flush the PEBS buffer.
>>
>> Drain the PEBS buffer in event read when large PEBS is enabled.
>>
>> For the threshold is one, even auto-reload is enabled, it doesn't need
>> to be specially handled. Because auto-reload is only effect when event
>> overflow. There is no overflow in event read.
>>
>> Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
>> ---
>>   arch/x86/events/intel/core.c |  9 +++++++++
>>   arch/x86/events/intel/ds.c   | 10 ++++++++++
>>   arch/x86/events/perf_event.h |  2 ++
>>   3 files changed, 21 insertions(+)
>>
>> diff --git a/arch/x86/events/intel/core.c b/arch/x86/events/intel/core.c
>> index 09c26a4..bdc35f8 100644
>> --- a/arch/x86/events/intel/core.c
>> +++ b/arch/x86/events/intel/core.c
>> @@ -2060,6 +2060,14 @@ static void intel_pmu_del_event(struct perf_event *event)
>>   		intel_pmu_pebs_del(event);
>>   }
>>   
>> +static void intel_pmu_read_event(struct perf_event *event)
>> +{
>> +	if (event->attr.precise_ip)
>> +		return intel_pmu_pebs_read(event);
> 
> check for (event->hw.flags & PERF_X86_EVENT_AUTO_RELOAD)
> would be more accurate?
> 

It will narrow down the events.
But considering the readability, I think it would be better to use 
precise_ip.The exposed functions in ds.c should be generic functions for 
all PEBS events, not specific case.
I think _AUTO_RELOAD looks too specific.

Thanks,
Kan