Date: Wed, 10 Jan 2018 06:57:43 -0800
From: Tejun Heo <tj@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: RCU: Call touch_nmi_watchdog() while printing stall warnings
Message-ID: <20180110145743.GD3668920@devbig577.frc2.facebook.com>
References: <20180109184709.GN3668920@devbig577.frc2.facebook.com>
 <20180110053450.GA1063@jagdpanzerIV>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180110053450.GA1063@jagdpanzerIV>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org

Hello,

On Wed, Jan 10, 2018 at 02:34:50PM +0900, Sergey Senozhatsky wrote:
> Tejun, while we are at it, shall we also touch NMI in show_workqueue_state()?
> I suppose that show_pwq() can be quite verbose on some systems, can't it?
> 
> for instance: sysrq-t [irq] -> show_workqueue_state()

Ah, it's less likely but definitely possible.

> diff --git a/kernel/workqueue.c b/kernel/workqueue.c
> index 9960f8842b31..649c00a9af12 100644
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -48,6 +48,7 @@
>  #include <linux/moduleparam.h>
>  #include <linux/uaccess.h>
>  #include <linux/sched/isolation.h>
> +#include <linux/nmi.h>
>  
>  #include "workqueue_internal.h"
>  
> @@ -4473,6 +4474,8 @@ void show_workqueue_state(void)
>  			if (pwq->nr_active || !list_empty(&pwq->delayed_works))
>  				show_pwq(pwq);
>  			spin_unlock_irqrestore(&pwq->pool->lock, flags);
> +
> +			touch_nmi_watchdog();

Can you send a patch w/ signed-off-by adding touch_nmi_watchdog() to
both outer loops in that function.  Theoretically, we can have a lot
of pools too.

Thanks.

-- 
tejun