Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965453AbeAJPIw (ORCPT + 1 other); Wed, 10 Jan 2018 10:08:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:33038 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965428AbeAJPIv (ORCPT ); Wed, 10 Jan 2018 10:08:51 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BC9D21723 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=chao@kernel.org Subject: Re: [f2fs-dev] [PATCH v2] f2fs: handle newly created page when revoking inmem pages To: Daeho Jeong , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <1515570550-4497-1-git-send-email-daeho.jeong@samsung.com> From: Chao Yu Message-ID: <8a0db638-ebe0-c7bd-5019-c00c87e4964e@kernel.org> Date: Wed, 10 Jan 2018 23:08:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1515570550-4497-1-git-send-email-daeho.jeong@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 2018/1/10 15:49, Daeho Jeong wrote: > When committing inmem pages is successful, we revoke already committed > blocks in __revoke_inmem_pages() and finally replace the committed > ones with the old blocks using f2fs_replace_block(). However, if > the committed block was newly created one, the address of the old > block is NEW_ADDR and __f2fs_replace_block() cannot handle NEW_ADDR > as new_blkaddr properly and a kernel panic occurrs. > > Signed-off-by: Daeho Jeong > Tested-by: Shu Tan Reviewed-by: Chao Yu Thanks,