Subject: Re: [Patch] Non-ASCII chars in visor.c messages
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Greg KH <greg@kroah.com>
Cc: Jan Kasprzak <kas@informatics.muni.cz>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
In-Reply-To: <20030722125039.GA2310@kroah.com>
References: <20030722143821.C26218@fi.muni.cz>
	 <20030722125039.GA2310@kroah.com>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Organization: 
Message-Id: <1058883388.2751.13.camel@dhcp22.swansea.linux.org.uk>
Mime-Version: 1.0
Date: 22 Jul 2003 15:16:28 +0100
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1237
Lines: 29

On Maw, 2003-07-22 at 13:50, Greg KH wrote:
> > 	The visor.c module contains three messages
> > with non-ASCII character ("e" with acute above, encoded in
> > ISO 8859-1, in the name of "Sony Clie'" handheld). I propose the attached
> > patch, which works in all environments (altough UTF-8 variant would be
> > IMHO fine as well).
> > 
> > 	What do you think about it?
> 
> I don't think it's really needed.  Why change this, syslog can't handle
> this?  It works for me...

Current syslog has problems handling it. These problems are a lot worse
than they appear too. Since the file system encoding is UTF-8 for file
naming the syslog daemon is sometimes logging kernel file path objects
which are unicode utf-8 format. 

The highbit corrupted characters in the C files (as well as being iffy
C) causes problems we just don't need. 

It doens't really matter if we pick UTF-8 (which does mean things like
names can be handled ok) or plain 7bit ascii C locale but we need to
pick something.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/