Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752235AbeAJRob (ORCPT + 1 other); Wed, 10 Jan 2018 12:44:31 -0500 Received: from terminus.zytor.com ([65.50.211.136]:59085 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751350AbeAJRo3 (ORCPT ); Wed, 10 Jan 2018 12:44:29 -0500 Date: Wed, 10 Jan 2018 09:37:53 -0800 From: tip-bot for David Woodhouse Message-ID: Cc: pjt@google.com, gregkh@linux-foundation.org, jikos@kernel.org, torvalds@linux-foundation.org, luto@amacapital.net, arjan@linux.intel.com, peterz@infradead.org, ak@linux.intel.com, riel@redhat.com, dwmw@amazon.co.uk, mingo@kernel.org, hpa@zytor.com, keescook@google.com, tglx@linutronix.de, tim.c.chen@linux.intel.com, linux-kernel@vger.kernel.org, dave.hansen@intel.com Reply-To: gregkh@linux-foundation.org, pjt@google.com, jikos@kernel.org, torvalds@linux-foundation.org, luto@amacapital.net, ak@linux.intel.com, peterz@infradead.org, arjan@linux.intel.com, riel@redhat.com, mingo@kernel.org, dwmw@amazon.co.uk, hpa@zytor.com, keescook@google.com, tglx@linutronix.de, dave.hansen@intel.com, linux-kernel@vger.kernel.org, tim.c.chen@linux.intel.com In-Reply-To: <1515508997-6154-10-git-send-email-dwmw@amazon.co.uk> References: <1515508997-6154-10-git-send-email-dwmw@amazon.co.uk> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/pti] x86/retpoline/checksum32: Convert assembler indirect jumps Git-Commit-ID: 6a2b9eb3c189a848fbfc5b3a0b282bc03bc142af X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Commit-ID: 6a2b9eb3c189a848fbfc5b3a0b282bc03bc142af Gitweb: https://git.kernel.org/tip/6a2b9eb3c189a848fbfc5b3a0b282bc03bc142af Author: David Woodhouse AuthorDate: Tue, 9 Jan 2018 14:43:15 +0000 Committer: Thomas Gleixner CommitDate: Wed, 10 Jan 2018 18:28:24 +0100 x86/retpoline/checksum32: Convert assembler indirect jumps Convert all indirect jumps in 32bit checksum assembler code to use non-speculative sequences when CONFIG_RETPOLINE is enabled. Signed-off-by: David Woodhouse Signed-off-by: Thomas Gleixner Acked-by: Arjan van de Ven Acked-by: Ingo Molnar Cc: gnomes@lxorguk.ukuu.org.uk Cc: Rik van Riel Cc: Andi Kleen Cc: Peter Zijlstra Cc: Linus Torvalds Cc: Jiri Kosina Cc: Andy Lutomirski Cc: Dave Hansen Cc: Kees Cook Cc: Tim Chen Cc: Greg Kroah-Hartman Cc: Paul Turner Link: https://lkml.kernel.org/r/1515508997-6154-10-git-send-email-dwmw@amazon.co.uk --- arch/x86/lib/checksum_32.S | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/x86/lib/checksum_32.S b/arch/x86/lib/checksum_32.S index 4d34bb5..46e71a7 100644 --- a/arch/x86/lib/checksum_32.S +++ b/arch/x86/lib/checksum_32.S @@ -29,7 +29,8 @@ #include #include #include - +#include + /* * computes a partial checksum, e.g. for TCP/UDP fragments */ @@ -156,7 +157,7 @@ ENTRY(csum_partial) negl %ebx lea 45f(%ebx,%ebx,2), %ebx testl %esi, %esi - jmp *%ebx + JMP_NOSPEC %ebx # Handle 2-byte-aligned regions 20: addw (%esi), %ax @@ -439,7 +440,7 @@ ENTRY(csum_partial_copy_generic) andl $-32,%edx lea 3f(%ebx,%ebx), %ebx testl %esi, %esi - jmp *%ebx + JMP_NOSPEC %ebx 1: addl $64,%esi addl $64,%edi SRC(movb -32(%edx),%bl) ; SRC(movb (%edx),%bl)