Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752341AbeAJSHL (ORCPT + 1 other); Wed, 10 Jan 2018 13:07:11 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:56589 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751891AbeAJSHK (ORCPT ); Wed, 10 Jan 2018 13:07:10 -0500 Date: Wed, 10 Jan 2018 19:06:27 +0100 (CET) From: Thomas Gleixner To: Tom Lendacky cc: linux-kernel@vger.kernel.org, peterz@infradead.org, tim.c.chen@linux.intel.com, gregkh@linux-foundation.org, hpa@zytor.com, mingo@kernel.org, dwmw@amazon.co.uk, luto@amacapital.net, riel@redhat.com, dave.hansen@intel.com, keescook@google.com, ak@linux.intel.com, pjt@google.com, torvalds@linux-foundation.org, jikos@kernel.org, linux-tip-commits@vger.kernel.org Subject: Re: [tip:x86/pti] x86/spectre: Add boot time option to select Spectre v2 mitigation In-Reply-To: <7689f631-7179-79f4-111b-418214432cc7@amd.com> Message-ID: References: <1515508997-6154-4-git-send-email-dwmw@amazon.co.uk> <7689f631-7179-79f4-111b-418214432cc7@amd.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, 10 Jan 2018, Tom Lendacky wrote: > > +retpoline_auto: > > + if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD) { > > Not specifying anything on the command line will get SPECTRE_V2_CMD_AUTO, > so boot_cpu_has(X86_FEATURE_LFENCE_RDTSC) needs to be checked since it > won't have been checked previously. Dammit.