DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B58A20C51
MIME-Version: 1.0
In-Reply-To: <20180110084242.GB3626@vireshk-i7>
References: <cover.1513264961.git.viresh.kumar@linaro.org> <20180109184733.GB28273@kroah.com>
 <20180110034440.GA3335@vireshk-i7> <20180110080801.GA30583@kroah.com> <20180110084242.GB3626@vireshk-i7>
From: Rob Herring <robh+dt@kernel.org>
Date: Wed, 10 Jan 2018 12:19:12 -0600
Message-ID: <CAL_JsqKX4t8mw=YHxtQbS65OhEjPA2ZpE+puDORxCGjUc_Miyg@mail.gmail.com>
Subject: Re: [PATCH V5 00/13] drivers: Boot Constraint core
To: Viresh Kumar <viresh.kumar@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
        Stephen Boyd <sboyd@codeaurora.org>,
        Rajendra Nayak <rnayak@codeaurora.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        Rob Clark <robdclark@gmail.com>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Lucas Stach <l.stach@pengutronix.de>,
        Shawn Guo <shawnguo@kernel.org>,
        Fabio Estevam <fabio.estevam@nxp.com>,
        Nishanth Menon <nm@ti.com>, Wei Xu <xuwei5@hisilicon.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org

On Wed, Jan 10, 2018 at 2:42 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 10-01-18, 09:08, Greg Kroah-Hartman wrote:
>> On Wed, Jan 10, 2018 at 09:14:40AM +0530, Viresh Kumar wrote:
>> > On 09-01-18, 19:47, Greg Kroah-Hartman wrote:
>> > > Can you resend this?  As you can tell, I've been a bit busy for the past
>> > > month or so :(
>> >
>> > Sure.
>> >
>> > > Also, why is there no signed-off-by on the OF core patches?
>> >
>> > A bit confused, sorry. Are you looking for my signed-off ? They are already
>> > there.
>> >
>> > Or are you looking for Rob's (OF maintainer) signed-off ?
>>
>> Looking for Rob's, why hasn't he reviewed this yet?

I did review the whole series on version v4... The whole thing seems
pretty hacky to me. OTOH, I don't know if there's an elegant solution
to this problem. This also tries to be a general solution for what's
largely an earlycon (which is, news flash, a debug tool) and displays
for which we already address at least some of this with simplefb (not
that it is a great solution either). I've yet to hear of any other
concrete uses for this.

> He went through them for sure but never gave his Ack. I have asked him to
> provide Acks for the first 2 patches this morning, if they look fine to him.

The drivers/of/ changes on their own are innocent enough if there's a
reason (We generally want users using of_platform_populate rather than
of_platform_bus_create, so that's why it's not exported now.). It's
really all the rest that concerns me.

Rob