Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752739AbeAJSf4 (ORCPT + 1 other); Wed, 10 Jan 2018 13:35:56 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:56717 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752006AbeAJSfy (ORCPT ); Wed, 10 Jan 2018 13:35:54 -0500 Date: Wed, 10 Jan 2018 19:35:19 +0100 (CET) From: Thomas Gleixner To: Tom Lendacky cc: mingo@kernel.org, peterz@infradead.org, linux-kernel@vger.kernel.org, ak@linux.intel.com, hpa@zytor.com, dave.hansen@intel.com, riel@redhat.com, torvalds@linux-foundation.org, luto@amacapital.net, gregkh@linux-foundation.org, jikos@kernel.org, tim.c.chen@linux.intel.com, pjt@google.com, dwmw@amazon.co.uk, keescook@google.com, linux-tip-commits@vger.kernel.org Subject: Re: [tip:x86/pti] x86/spectre: Add boot time option to select Spectre v2 mitigation In-Reply-To: <1835548e-8f64-9e3b-59c2-9391ec5b7f13@amd.com> Message-ID: References: <1515508997-6154-4-git-send-email-dwmw@amazon.co.uk> <1835548e-8f64-9e3b-59c2-9391ec5b7f13@amd.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, 10 Jan 2018, Tom Lendacky wrote: > > + } else if (match_option(arg, ret, "retpoline,amd")) { > > + if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD) { > > I missed this in the first review, but this should be != X86_VENDOR_AMD. > Sorry about that. I stared at it when doing the move of the other check and failed to see it.