Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751851AbeAJTyc (ORCPT + 1 other); Wed, 10 Jan 2018 14:54:32 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:54260 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751689AbeAJTyb (ORCPT ); Wed, 10 Jan 2018 14:54:31 -0500 Date: Wed, 10 Jan 2018 14:54:29 -0500 (EST) Message-Id: <20180110.145429.139747567601766196.davem@davemloft.net> To: yangbo.lu@nxp.com Cc: festevam@gmail.com, claudiu.manoil@nxp.com, richardcochran@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [v2] net: gianfar_ptp: move set_fipers() to spinlock protecting area From: David Miller In-Reply-To: <20180109030233.16013-1-yangbo.lu@nxp.com> References: <20180109030233.16013-1-yangbo.lu@nxp.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 10 Jan 2018 11:54:31 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: From: Yangbo Lu Date: Tue, 9 Jan 2018 11:02:33 +0800 > set_fipers() calling should be protected by spinlock in > case that any interrupt breaks related registers setting > and the function we expect. This patch is to move set_fipers() > to spinlock protecting area in ptp_gianfar_adjtime(). > > Signed-off-by: Yangbo Lu > --- > Changes for v2: > - explained why spinlock was needed in commit message. Applied.