Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752493AbeAJUGb (ORCPT + 1 other); Wed, 10 Jan 2018 15:06:31 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:54494 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752345AbeAJUG2 (ORCPT ); Wed, 10 Jan 2018 15:06:28 -0500 Date: Wed, 10 Jan 2018 15:06:27 -0500 (EST) Message-Id: <20180110.150627.1824860958372498944.davem@davemloft.net> To: wangxiongfeng2@huawei.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] caif_usb: use strlcpy() instead of strncpy() From: David Miller In-Reply-To: <1515499098-159956-1-git-send-email-wangxiongfeng2@huawei.com> References: <1515499098-159956-1-git-send-email-wangxiongfeng2@huawei.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 10 Jan 2018 12:06:28 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: From: Xiongfeng Wang Date: Tue, 9 Jan 2018 19:58:18 +0800 > From: Xiongfeng Wang > > gcc-8 reports > > net/caif/caif_usb.c: In function 'cfusbl_device_notify': > ./include/linux/string.h:245:9: warning: '__builtin_strncpy' output may > be truncated copying 15 bytes from a string of length 15 > [-Wstringop-truncation] > > The compiler require that the input param 'len' of strncpy() should be > greater than the length of the src string, so that '\0' is copied as > well. We can just use strlcpy() to avoid this warning. > > Signed-off-by: Xiongfeng Wang Applied.