Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752380AbeAJUIi (ORCPT + 1 other); Wed, 10 Jan 2018 15:08:38 -0500 Received: from gate2.alliedtelesis.co.nz ([202.36.163.20]:53957 "EHLO gate2.alliedtelesis.co.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751770AbeAJUIg (ORCPT ); Wed, 10 Jan 2018 15:08:36 -0500 From: Chris Packham To: Gregory CLEMENT CC: "jlu@pengutronix.de" , "linux@armlinux.org.uk" , "bp@alien8.de" , "linux-arm-kernel@lists.infradead.org" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Jason Cooper , "Andrew Lunn" , Sebastian Hesselbarth , Rob Herring , "Mark Rutland" , "devicetree@vger.kernel.org" Subject: Re: [PATCH 1/3] ARM: dts: enable L2 cache parity and ecc on db-xc3-24g4xg board Thread-Topic: [PATCH 1/3] ARM: dts: enable L2 cache parity and ecc on db-xc3-24g4xg board Thread-Index: AQHTiexgpNdc9gBsEUuLR/7W6z1NCA== Date: Wed, 10 Jan 2018 20:08:31 +0000 Message-ID: <236e468acaef47d6847809d09a88ee06@svr-chch-ex1.atlnz.lc> References: <20180108223158.21930-1-chris.packham@alliedtelesis.co.nz> <20180108223158.21930-2-chris.packham@alliedtelesis.co.nz> <87y3l66s0r.fsf@free-electrons.com> Accept-Language: en-NZ, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [2001:df5:b000:22:3a2c:4aff:fe70:2b02] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hi Gregory, On 10/01/18 21:24, Gregory CLEMENT wrote: > Hi Chris, > > On mar., janv. 09 2018, Chris Packham wrote: > > Could you have add a (even small) message in the commit log? > > Also could you improve the title by specify that it applies on > armada-xp, like this: > > ARM: dts: armada-xp: enable L2 cache parity and ecc on db-xc3-24g4xg > Will do. >> Signed-off-by: Chris Packham >> --- >> arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts b/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts >> index 06fce35d7491..00ca489fc788 100644 >> --- a/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts >> +++ b/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts >> @@ -70,6 +70,11 @@ >> }; >> }; >> >> +&L2 { >> + arm,parity-enable; >> + marvell,ecc-enable; > > It is not a problem for me to already applied the device tree change > even if the driver is not merged yet. But I would like to have an > acked-by on this new property by either a device tree maintainer or at > least the EDAC maintainer, of course having both acked-by would be > perfect ! :) Thanks, I was hoping you would say that. That way I can keep this independent of the EDAC driver changes. > > Thanks, > > Gregory > > > > >> +}; >> + >> &devbus_bootcs { >> status = "okay"; >> >> -- >> 2.15.1 >> >