Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752604AbeAJUlw (ORCPT + 1 other); Wed, 10 Jan 2018 15:41:52 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:34557 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752028AbeAJUlu (ORCPT ); Wed, 10 Jan 2018 15:41:50 -0500 X-Google-Smtp-Source: ACJfBovz7my93scCLKLlxb1qz7YFfxrLhn1tHKfeiCNyr2P5qthocACoqmVWOvP8Nr691kCnIBkqag== Subject: Re: [PATCH] leds: ledtrig-transient: Add SPDX license identifiers To: Shuah Khan , rpurdie@rpsys.net, pavel@ucw.cz, keescook@chromium.org, shuah@kernel.org References: <20180110163540.8396-1-shuahkh@osg.samsung.com> Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org From: Jacek Anaszewski X-Enigmail-Draft-Status: N1110 Message-ID: Date: Wed, 10 Jan 2018 21:40:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20180110163540.8396-1-shuahkh@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hi Shuah, Thanks for the patch. On 01/10/2018 05:35 PM, Shuah Khan wrote: > Replace GPL license statements with SPDX GPL-2.0 license identifiers > and and correct the module license to GPLv2. > > Signed-off-by: Shuah Khan > --- > drivers/leds/trigger/ledtrig-transient.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/leds/trigger/ledtrig-transient.c b/drivers/leds/trigger/ledtrig-transient.c > index 7acce64b692a..f0578af858e7 100644 > --- a/drivers/leds/trigger/ledtrig-transient.c > +++ b/drivers/leds/trigger/ledtrig-transient.c > @@ -1,3 +1,4 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > /* How about changing this whole block comment to "//"? We did it already for drivers/leds/trigger/ledtrig-netdev.c, present in linux-next. See related discussion with reference to relevant Linus' guidelines in this matter [0]. > * LED Kernel Transient Trigger > * > @@ -8,10 +9,6 @@ > * Design and use-case input from Jonas Bonn and > * Neil Brown > * > - * This program is free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License version 2 as > - * published by the Free Software Foundation. > - * > */ > /* > * Transient trigger allows one shot timer activation. Please refer to > @@ -238,4 +235,4 @@ module_exit(transient_trig_exit); > > MODULE_AUTHOR("Shuah Khan "); > MODULE_DESCRIPTION("Transient LED trigger"); > -MODULE_LICENSE("GPL"); > +MODULE_LICENSE("GPL v2"); > [0] https://www.mail-archive.com/netdev@vger.kernel.org/msg204598.html -- Best regards, Jacek Anaszewski