Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752648AbeAJVLk (ORCPT + 1 other); Wed, 10 Jan 2018 16:11:40 -0500 Received: from mail-oi0-f65.google.com ([209.85.218.65]:46756 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752371AbeAJVLi (ORCPT ); Wed, 10 Jan 2018 16:11:38 -0500 X-Google-Smtp-Source: ACJfBovXVrmsQ7aQ6XK+iTk3hEEsooikk0rO5c037V230Ajzia/ke/jL+K0A7vHxuCnQEedlWwLzYpavLGGn7sy4dBY= MIME-Version: 1.0 In-Reply-To: References: <20180110163812.687838-1-arnd@arndb.de> From: Arnd Bergmann Date: Wed, 10 Jan 2018 22:11:37 +0100 X-Google-Sender-Auth: 0TI5LQfQmDqGXswCAjpzOQtizCU Message-ID: Subject: Re: [PATCH] net/9p: trans_xen: add missing MODULE_AUTHOR/DESCRIPTION/LICENSE To: Akemi Yagi Cc: Networking , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, Jan 10, 2018 at 6:27 PM, Akemi Yagi wrote: > On Wed, 10 Jan 2018 17:37:47 +0100, Arnd Bergmann wrote: >> >> MODULE_DESCRIPTION and MODULE_AUTHOR are also added. >> >> Signed-off-by: Jesse Chan >> Signed-off-by: Arnd Bergmann >> --- >> net/9p/trans_xen.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/net/9p/trans_xen.c b/net/9p/trans_xen.c >> index 325c56043007..336576f7e9f1 100644 >> --- a/net/9p/trans_xen.c >> +++ b/net/9p/trans_xen.c >> @@ -543,3 +543,7 @@ static void p9_trans_xen_exit(void) >> return xenbus_unregister_driver(&xen_9pfs_front_driver); >> } >> module_exit(p9_trans_xen_exit); >> + >> +MODULE_AUTHOR("Stefano Stabellini "); >> +MODULE_DESCRIPTION("Xen Transport for 9P"); >> +MODULE_LICENSE("Dual MIT/GPL"); > > Could you consider adding the credit to the people who are in this patch that addresses the same issue? > > https://patchwork.ozlabs.org/patch/856908/ Any version is fine with me, as long as the patch makes it in. I picked up Jesse's patch and forwarded that one, as he seems to have been the first person to send a patch back in November. Comparing the two versions, I think that one is also better since it correctly identifies the license as "Dual MIT/GPL", matching the comment. Arnd