From: Jeff Moyer <jmoyer@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: viro@zeniv.linux.org.uk, Avi Kivity <avi@scylladb.com>,
        linux-aio@kvack.org, linux-fsdevel@vger.kernel.org,
        netdev@vger.kernel.org, linux-api@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 26/32] aio: refactor read/write iocb setup
References: <20180110155853.32348-1-hch@lst.de>
        <20180110155853.32348-27-hch@lst.de>
Date: Wed, 10 Jan 2018 16:19:53 -0500
In-Reply-To: <20180110155853.32348-27-hch@lst.de> (Christoph Hellwig's message
        of "Wed, 10 Jan 2018 16:58:47 +0100")
Message-ID: <x49po6h4dja.fsf@segfault.boston.devel.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org

Christoph Hellwig <hch@lst.de> writes:

> Don't reference the kiocb structure from the common aio code, and move
> any use of it into helper specific to the read/write path.  This is in
> preparation for aio_poll support that wants to use the space for different
> fields.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

I think this all looks okay (making sure everything was still cleaned up
in the error cases was a bit of a chore).  One nit below.

> +static int aio_prep_rw(struct kiocb *req, struct iocb *iocb)
> +{
> +	int ret;
> +
> +	req->ki_filp = fget(iocb->aio_fildes);
> +	if (unlikely(!req->ki_filp))
> +		return -EBADF;
> +	req->ki_complete = aio_complete_rw;
> +	req->ki_flags = 0;

The above assignment seems superfluous...

> +	req->ki_pos = iocb->aio_offset;
> +	req->ki_flags = iocb_flags(req->ki_filp);

because of this.

Acked-by: Jeff Moyer <jmoyer@redhat.com>