Subject: Re: [PATCH v3 0/5] x86: SME: BSP/SME microcode update fix
To: Gabriel C <nix.or.die@gmail.com>, x86@kernel.org
Cc: Brijesh Singh <brijesh.singh@amd.com>,
        linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Thomas Gleixner <tglx@linutronix.de>
References: <20180110192544.6026.17285.stgit@tlendack-t1.amdoffice.net>
 <fbab2c46-52b7-dfb4-e11a-153f8064382f@gmail.com>
From: Tom Lendacky <thomas.lendacky@amd.com>
Message-ID: <39709df3-fd62-28d6-9e78-94681b393ac9@amd.com>
Date: Wed, 10 Jan 2018 15:26:03 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <fbab2c46-52b7-dfb4-e11a-153f8064382f@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2018 21:26:05.7433 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 218e77bc-2147-451f-3ea3-08d55870c261
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1144
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On 1/10/2018 3:14 PM, Gabriel C wrote:
> On 10.01.2018 20:25, Tom Lendacky wrote:
> 
> Hi Tom ,
> 
>> This patch series addresses an issue when SME is active and the BSP
>> is attempting to check for and load microcode during load_ucode_bsp().
>> Since the initrd has not been decrypted (yet) and the virtual address
>> of the initrd treats the memory as encrypted, the CPIO archive parsing
>> fails to locate the microcode.
>>
>> This series moves the encryption of the initrd into the early boot code
>> and encrypts it at the same time that the kernel is encrypted.  Since
>> the initrd is now encrypted, the CPIO archive parsing succeeds in
>> properly locating the microcode.
>>
>> The following patches are included in this fix:
>> - Cleanup register saving in arch/x86/mm/mem_encrypt_boot.S
>> - Reduce parameters and complexity for creating the SME PGD mappings
>> - Centralize the use of the PMD flags used in sme_encrypt_kernel() in
>>    preparation for using PTE flags also.
>> - Prepare sme_encrypt_kernel() to handle PAGE aligned encryption, not
>>    just 2MB large page aligned encryption.
>> - Encrypt the initrd in sme_encrypt_kernel() when the kernel is being
>>    encrypted.
>>
>> This patch series is based on tip/master.
> 
> Is something in tip/master the patch serie need ?

That's just how I have to submit the patches.  You could try applying them
onto whatever tree you like, I don't imagine any conflicts would be too
difficult to resolve if you encounter any.

Thanks,
Tom

> 
> I would like to test the serie however tip/master
> breaks my box.. On tip/master there is no way to boot
> with mem_crypt=on with or without your patches.
> 
> With mem_crypt=off the box at least boots to a point , seems APCI breaks
> on tip/master.
> 
> If someone want to take a look , a dmesg of the broken boot can be found
> there:
> 
> http://sigsegv.24-7.ro/~crazy/tip-master/dmesg-tip-master.txt
> 
> Regards,
> 
> Gabriel C
> 
>