Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752096AbeAJVp0 (ORCPT + 1 other); Wed, 10 Jan 2018 16:45:26 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:53344 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751740AbeAJVpZ (ORCPT ); Wed, 10 Jan 2018 16:45:25 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 56BC66032D Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Wed, 10 Jan 2018 13:45:21 -0800 From: Stephen Boyd To: sean.wang@mediatek.com Cc: mturquette@baylibre.com, matthias.bgg@gmail.com, jdelvare@suse.de, jamesjj.liao@mediatek.com, weiyi.lu@mediatek.com, kevin-cw.chen@mediatek.com, shunli.wang@mediatek.com, chen.zhong@mediatek.com, arnd@arndb.de, linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] clk: mediatek: adjust dependency of reset.c to avoid unexpectedly being built Message-ID: <20180110214521.GE28313@codeaurora.org> References: <0a88c7902606e819438ef0f1fc5968960e718620.1515139760.git.sean.wang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0a88c7902606e819438ef0f1fc5968960e718620.1515139760.git.sean.wang@mediatek.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/05, sean.wang@mediatek.com wrote: > From: Sean Wang > > Changes from v1->v2: > Add 'select RESET_CONTROLLER' under COMMON_CLK_MEDIATEK and enable > reset.c to be built when COMMON_CLK_MEDIATEK is selected. That should > be quite reasonable because the reset controller is tightly embedded > inside and exported from these clock subsystems. At least it can be found > on infracfg and pericfg subsystem that both are really fundamental block > lots of devices must depend on. > > commit 74cb0d6dde8 ("clk: mediatek: fixup test-building of MediaTek clock > drivers") can let the build system looking into the directory where the > clock drivers resides and then allow test-building the drivers. > > But the change also gives rise to certain incorrect behavior which is > reset.c being built even not depending on either COMPILE_TEST or > ARCH_MEDIATEK alternative dependency. To get rid of reset.c being built > unexpectedly on the other platforms, it would be a good change that the > file should be built depending on its own specific configuration rather > than just on generic RESET_CONTROLLER one. > > Signed-off-by: Sean Wang > Cc: Jean Delvare > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project