Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752530AbeAJWnK (ORCPT + 1 other); Wed, 10 Jan 2018 17:43:10 -0500 Received: from osg.samsung.com ([64.30.133.232]:60657 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752345AbeAJWnJ (ORCPT ); Wed, 10 Jan 2018 17:43:09 -0500 Subject: Re: [PATCH] leds: ledtrig-transient: Add SPDX license identifiers To: Jacek Anaszewski , rpurdie@rpsys.net, pavel@ucw.cz, keescook@chromium.org, shuah@kernel.org Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20180110163540.8396-1-shuahkh@osg.samsung.com> From: Shuah Khan Message-ID: <9a26debc-e04d-e935-d2d8-bba1df6d92e5@osg.samsung.com> Date: Wed, 10 Jan 2018 15:43:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/10/2018 01:40 PM, Jacek Anaszewski wrote: > Hi Shuah, > > Thanks for the patch. > > On 01/10/2018 05:35 PM, Shuah Khan wrote: >> Replace GPL license statements with SPDX GPL-2.0 license identifiers >> and and correct the module license to GPLv2. >> >> Signed-off-by: Shuah Khan >> --- >> drivers/leds/trigger/ledtrig-transient.c | 7 ++----- >> 1 file changed, 2 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/leds/trigger/ledtrig-transient.c b/drivers/leds/trigger/ledtrig-transient.c >> index 7acce64b692a..f0578af858e7 100644 >> --- a/drivers/leds/trigger/ledtrig-transient.c >> +++ b/drivers/leds/trigger/ledtrig-transient.c >> @@ -1,3 +1,4 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> /* > > How about changing this whole block comment to "//"? > We did it already for drivers/leds/trigger/ledtrig-netdev.c, > present in linux-next. See related discussion with reference > to relevant Linus' guidelines in this matter [0]. > v2 is on its way. thanks, -- Shuah