Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753314AbeAJX0n (ORCPT + 1 other); Wed, 10 Jan 2018 18:26:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38564 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752521AbeAJX0l (ORCPT ); Wed, 10 Jan 2018 18:26:41 -0500 From: Jeff Moyer To: Christoph Hellwig Cc: viro@zeniv.linux.org.uk, Avi Kivity , linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 30/32] aio: add delayed cancel support References: <20180110155853.32348-1-hch@lst.de> <20180110155853.32348-31-hch@lst.de> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Wed, 10 Jan 2018 18:26:39 -0500 In-Reply-To: (Jeff Moyer's message of "Wed, 10 Jan 2018 17:59:13 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 10 Jan 2018 23:26:41 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Jeff Moyer writes: > Christoph Hellwig writes: > >> The upcoming aio poll support would like to be able to complete the >> iocb inline from the cancellation context, but that would cause >> a lock order reversal. Add support for optionally moving the cancelation >> outside the context lock to avoid this reversal. >> >> Signed-off-by: Christoph Hellwig > > Acked-by: Jeff Moyer Actually, let's move these two defines: #define AIO_IOCB_DELAYED_CANCEL (1 << 0) #define AIO_IOCB_CANCELLED (1 << 1) to include/linux/aio.h so that drivers outside of fs/aio.c can make use of them. -Jeff