Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752804AbeAKAA5 (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Wed, 10 Jan 2018 19:00:57 -0500
Received: from mail-qk0-f179.google.com ([209.85.220.179]:37454 "EHLO
        mail-qk0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752432AbeAKAA4 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 10 Jan 2018 19:00:56 -0500
X-Google-Smtp-Source: ACJfBouK3SEjzrZ6GPw5GzCBkw2O14Q+vV52JUIUYYD1KWSrgwo8PbRv5YEWj8vGhCZI/STJQqxWew==
Subject: =?UTF-8?Q?Re:_=e7=ad=94=e5=a4=8d:_[PATCH]_ION:_Sys=5fheap:_fix_the_?=
 =?UTF-8?Q?incorrect_pool->gfp=5fmask_setting?=
To: "Zengtao (B)" <prime.zeng@hisilicon.com>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        "Chenfeng (puck)" <puck.chen@hisilicon.com>
Cc: "sumit.semwal@linaro.org" <sumit.semwal@linaro.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "arve@android.com" <arve@android.com>,
        "tkjos@android.com" <tkjos@android.com>,
        "maco@android.com" <maco@android.com>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <1515494623-8383-1-git-send-email-prime.zeng@hisilicon.com>
 <5A543741.9060806@hisilicon.com> <20180109091428.sewxoc7vrtox33ai@mwanda>
 <678F3D1BB717D949B966B68EAEB446ED0C83060D@DGGEMM506-MBX.china.huawei.com>
From: Laura Abbott <labbott@redhat.com>
Message-ID: <f1c7c53d-0c7f-e66e-2d0f-f5d12486c627@redhat.com>
Date: Wed, 10 Jan 2018 16:00:51 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <678F3D1BB717D949B966B68EAEB446ED0C83060D@DGGEMM506-MBX.china.huawei.com>
Content-Type: text/plain; charset=gbk; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On 01/09/2018 04:06 AM, Zengtao (B) wrote:
>> -----?ʼ?ԭ??-----
>> ??????: Dan Carpenter [mailto:dan.carpenter@oracle.com]
>> ????ʱ??: 2018??1??9?? 17:14
>> ?ռ???: Chenfeng (puck) <puck.chen@hisilicon.com>
>> ????: Zengtao (B) <prime.zeng@hisilicon.com>; labbott@redhat.com;
>> sumit.semwal@linaro.org; gregkh@linuxfoundation.org; arve@android.com;
>> tkjos@android.com; maco@android.com; devel@driverdev.osuosl.org;
>> linux-kernel@vger.kernel.org
>> ????: Re: [PATCH] ION: Sys_heap: fix the incorrect pool->gfp_mask setting
>>
>> On Tue, Jan 09, 2018 at 11:30:09AM +0800, Chen Feng wrote:
>>>
>>>
>>> On 2018/1/9 18:43, Zeng Tao wrote:
>>>> This issue is introduced by the commit <e7f63771b60e> ("ION: Sys_heap:
>>>> Add cached pool to spead up cached buffer alloc"),
>>
>> Use the Fixes tag.
>>
>> Fixes: e7f63771b60e ("ION: Sys_heap: Add cached pool to spead up cached
>> buffer alloc")
>>
> Agree, thanks.
> 

If you're going to be fixing this, it would be good to
fix the other problems pointed out (stop with the
#define of the flags).

Thanks,
Laura