Subject: Re: EDAC-AMD64: what is the ecc_msg good for ?
To: Borislav Petkov <bp@alien8.de>
Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
References: <5dea4184-8782-7b57-2624-2957c91fe4ac@gmail.com>
 <20180110231235.a3ts353lzajqywb5@pd.tnic>
 <5be13f07-aeae-ee07-1194-f882eb958ac8@gmail.com>
 <20180110234524.a5qggzxslvrmi4ul@pd.tnic>
From: Gabriel C <nix.or.die@gmail.com>
Message-ID: <c138f95d-5bed-6d90-f170-404d32dd5ab8@gmail.com>
Date: Thu, 11 Jan 2018 01:27:15 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <20180110234524.a5qggzxslvrmi4ul@pd.tnic>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On 11.01.2018 00:45, Borislav Petkov wrote:
> On Thu, Jan 11, 2018 at 12:31:08AM +0100, Gabriel C wrote:
>> Beacuse we see the following:
>>
>> [    4.694948] EDAC amd64: Node 6: DRAM ECC disabled.
>> [    4.694949] EDAC amd64: ECC disabled in the BIOS or no ECC capability, module will not load.
>>                  Either enable ECC checking or force module loading by setting 'ecc_enable_override'.
>>                  (Note that use of the override may cause unknown side effects.)
>>
>> The first one tells the Node is disabled
> 
> The first one says *DRAM ECC* is disabled on that node - not the node
> itself. Looks like it confuses you too.

Yes ofc :) is what I meant :)

> 
>> the second is a
>> KERN INFO message telling the *module* will not load.
>>
>> Telling then *module* will not load for 'this Node' should be clear for everone.
> 
> So this is a purely informational message. There's a lot of messages
> like that in the kernel. I still don't understand what your problem is
> with this particular one.

Nothing agains messages but I get this one twice for each node is disabled
with a INFO I partially don't even need on that platform.

> 
>> Don't get me wrong for me is clear what this means , I don't need the
>> second message at all but I have here folks didn't understand wth that means.
> 
> "ECC disabled in the BIOS or no ECC capability, module will not load." -
> I think that sentence is explaining the situation pretty good:
> 
> either ECC checking is disabled in the BIOS
> 
> or
> 
> ECC capability cannot be detected.
> 
> What do you think it should say instead?

The message is fine if you add a Node prefix on it and let the
that ecc_enable_override stuff out.

something like this looks better and less confusing , don't you think ?

  EDAC amd64: Node 4: DRAM ECC disabled.
  EDAC amd64: Node 4: DDRM ECC disabled in the BIOS or no ECC capability, module will not load.
  EDAC amd64: Node 5: DRAM ECC enabled.
  EDAC amd64: F17h detected (node 5).
  EDAC MC: UMC0 chip selects:
  ....