Subject: Re: [PATCH net-next V2 2/2] tuntap: XDP transmission
To: Tariq Toukan <tariqt@mellanox.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc: mst@redhat.com, jbrouer@redhat.com,
        Jesper Dangaard Brouer <brouer@redhat.com>
References: <1515035668-6241-1-git-send-email-jasowang@redhat.com>
 <1515035668-6241-3-git-send-email-jasowang@redhat.com>
 <aede4fe5-baac-f50e-1ece-9b3562c03a6d@mellanox.com>
From: Jason Wang <jasowang@redhat.com>
Message-ID: <668445bc-5920-23a6-c59f-3b09e2c4fed1@redhat.com>
Date: Thu, 11 Jan 2018 10:35:10 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <aede4fe5-baac-f50e-1ece-9b3562c03a6d@mellanox.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org


On 2018年01月11日 00:11, Tariq Toukan wrote:
>> +EXPORT_SYMBOL(tun_ptr_to_xdp);
>> +
>
> Hi Jason,
> I started getting the following compilation issues.
>
> + make -j24 -s
> net/socket.o: In function `tun_xdp_to_ptr':
> /images/autom/buildbot/worker/merge-net-next/build/./include/linux/if_tun.h:46: 
> multiple definition of `tun_xdp_to_ptr'
> fs/compat_ioctl.o:/images/autom/buildbot/worker/merge-net-next/build/./include/linux/if_tun.h:46: 
> first defined here
> net/socket.o: In function `tun_ptr_to_xdp':
> /images/autom/buildbot/worker/merge-net-next/build/./include/linux/if_tun.h:50: 
> multiple definition of `tun_ptr_to_xdp'
> fs/compat_ioctl.o:/images/autom/buildbot/worker/merge-net-next/build/./include/linux/if_tun.h:50: 
> first defined here
> make: *** [vmlinux] Error 1
>
> Seems you missed adding the following ifdef:
> #if defined(CONFIG_TUN) || defined(CONFIG_TUN_MODULE)
>
> Thanks,
> Tariq 

My bad and sorry for that.

It should have been fixed by 
https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=1125b008711581a8962ee028e2982d7757093600

Thanks