Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754169AbeAKFKq (ORCPT + 1 other); Thu, 11 Jan 2018 00:10:46 -0500 Received: from mail-pf0-f179.google.com ([209.85.192.179]:33881 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754020AbeAKFKm (ORCPT ); Thu, 11 Jan 2018 00:10:42 -0500 X-Google-Smtp-Source: ACJfBouDPp1aWA2cpxp9vuKpX6jjSSznQzkfm1ntsJ/c6cyggfkIjY3rSKyVAHwBGCJ0R+Vl4TexAA== Date: Thu, 11 Jan 2018 14:10:36 +0900 From: Sergey Senozhatsky To: Petr Mladek Cc: Tejun Heo , Steven Rostedt , Sergey Senozhatsky , akpm@linux-foundation.org, linux-mm@kvack.org, Cong Wang , Dave Hansen , Johannes Weiner , Mel Gorman , Michal Hocko , Vlastimil Babka , Peter Zijlstra , Linus Torvalds , Jan Kara , Mathieu Desnoyers , Tetsuo Handa , rostedt@home.goodmis.org, Byungchul Park , Sergey Senozhatsky , Pavel Machek , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 0/2] printk: Console owner and waiter logic cleanup Message-ID: <20180111051036.GB494@jagdpanzerIV> References: <20180110132418.7080-1-pmladek@suse.com> <20180110140547.GZ3668920@devbig577.frc2.facebook.com> <20180110162900.GA21753@linux.suse> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180110162900.GA21753@linux.suse> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On (01/10/18 17:29), Petr Mladek wrote: [..] > The next versions used lazy offload from console_unlock() when > the thread spent there too much time. IMHO, this is one > very promising solution. It guarantees that softlockup > would never happen. But it tries hard to get the messages > out immediately. a small addition. my motivation was not exactly the "lazy offload", but to keep the existing printk behavior as long as possible. and that "as long as possible" is determined by watchdog threshold, which is the only limit we must care about. as long as printing task spends more than 1/2 of watchdog threshold - we offload. otherwise we don't mess up with the existing logic/guarantees/etc. there is also a bunch of other things in the patch now. but nothing fantastically complex. -ss