Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932152AbeAKHG2 (ORCPT + 1 other); Thu, 11 Jan 2018 02:06:28 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:44239 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753948AbeAKHG0 (ORCPT ); Thu, 11 Jan 2018 02:06:26 -0500 X-Google-Smtp-Source: ACJfBotiv6L6vHNfh4dAdEKnXs0dx33aNQYxqFpKzgS1SMpbGmUn33n5Fw1zA8+NKnM3/fzwI3+fHQ== Date: Thu, 11 Jan 2018 16:06:22 +0900 From: Sergey Senozhatsky To: Nick Desaulniers Cc: akpm@linux-foundation.org, Andy Shevchenko , Matthew Wilcox , Minchan Kim , Nitin Gupta , Sergey Senozhatsky , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] zsmalloc: use U suffix for negative literals being shifted Message-ID: <20180111070622.GI494@jagdpanzerIV> References: <20180110055338.h3cs5hw7mzsdtcad@eng-minchan1.roam.corp.google.com> <1515642078-4259-1-git-send-email-nick.desaulniers@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1515642078-4259-1-git-send-email-nick.desaulniers@gmail.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On (01/10/18 19:41), Nick Desaulniers wrote: > Fixes warnings about shifting unsigned literals being undefined > behavior. > > Suggested-by: Minchan Kim > Signed-off-by: Nick Desaulniers looks good to me. Reviewed-by: Sergey Senozhatsky -ss