Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933159AbeAKKB7 (ORCPT + 1 other); Thu, 11 Jan 2018 05:01:59 -0500 Received: from ozlabs.org ([103.22.144.67]:57773 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932678AbeAKKBz (ORCPT ); Thu, 11 Jan 2018 05:01:55 -0500 Date: Thu, 11 Jan 2018 21:01:48 +1100 From: Paul Mackerras To: Alexander Graf Cc: kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH] KVM: PPC: Book3S HV: Remove vcpu->arch.dec usage Message-ID: <20180111100148.GJ24294@fergus.ozlabs.ibm.com> References: <20171219145624.46724-1-agraf@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171219145624.46724-1-agraf@suse.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Dec 19, 2017 at 03:56:24PM +0100, Alexander Graf wrote: > On Book3S in HV mode, we don't use the vcpu->arch.dec field at all. > Instead, all logic is built around vcpu->arch.dec_expires. > > So let's remove the one remaining piece of code that was setting it. > > Signed-off-by: Alexander Graf Thanks, applied to my kvm-ppc-next branch. > Looking through the DEC logic, I fail to see any code that allows > save or restore of DEC. Do we maybe miss out on that register for > (live) migration? Yes, it looks like we do. I'm amazed no-one has noticed before. I'll fix it. Paul.