Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933271AbeAKKO7 (ORCPT + 1 other); Thu, 11 Jan 2018 05:14:59 -0500 Received: from mail-wm0-f44.google.com ([74.125.82.44]:42082 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753757AbeAKKO4 (ORCPT ); Thu, 11 Jan 2018 05:14:56 -0500 X-Google-Smtp-Source: ACJfBotoxg/XAHJrxULn/5NMLcKZ8w0SCNFdgn21BI5xbpoDc63VrlX623/4fGJWCM9X932ruBFB3g== Date: Thu, 11 Jan 2018 11:14:52 +0100 From: Ahmed Abdelsalam To: Pablo Neira Ayuso Cc: kadlec@blackhole.kfki.hu, fw@strlen.de, davem@davemloft.net, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org Subject: Re: [iptables] extensions: add support for 'srh' match Message-Id: <20180111111452.2ace1cdde68b3a11a2144a00@gmail.com> In-Reply-To: <20180110153224.3qtwicyu3sjzu2ec@salvia> References: <1514545705-13868-1-git-send-email-amsalam20@gmail.com> <20180110153224.3qtwicyu3sjzu2ec@salvia> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.21; x86_64-apple-darwin10.8.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, 10 Jan 2018 16:32:24 +0100 Pablo Neira Ayuso wrote: > On Fri, Dec 29, 2017 at 12:08:25PM +0100, Ahmed Abdelsalam wrote: > > This patch adds a new exetension to iptables to supprt 'srh' match > > The implementation considers revision 7 of the SRH draft. > > https://tools.ietf.org/html/draft-ietf-6man-segment-routing-header-07 > > > > Signed-off-by: Ahmed Abdelsalam > > --- > > extensions/libip6t_srh.c | 283 ++++++++++++++++++++++++++++++++ > > include/linux/netfilter_ipv6/ip6t_srh.h | 63 +++++++ > > Please, add a extensions/libip6t_srh.t test file and send a v2. > > Thanks. Ok, Is there minimum requirements of the test cases to be added to the extensions/libip6t_srh.t file ? -- Ahmed