Message-ID: <1515673958.7000.899.camel@linux.intel.com>
Subject: Re: [PATCH v1 1/4] bitmap: Add bitmap_zero()/bitmap_clear() test
 cases
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yury Norov <ynorov@caviumnetworks.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Randy Dunlap <rdunlap@infradead.org>
Date: Thu, 11 Jan 2018 14:32:38 +0200
In-Reply-To: <20180111120719.johxsu3jg6chbsjz@yury-thinkpad>
References: <20180109172430.87452-1-andriy.shevchenko@linux.intel.com>
         <20180110093405.zhz3smxy264kmghv@yury-thinkpad>
         <1515589905.7000.847.camel@linux.intel.com>
         <20180111120719.johxsu3jg6chbsjz@yury-thinkpad>
Organization: Intel Finland Oy
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Thu, 2018-01-11 at 15:07 +0300, Yury Norov wrote:
> On Wed, Jan 10, 2018 at 03:11:45PM +0200, Andy Shevchenko wrote:
> > On Wed, 2018-01-10 at 12:34 +0300, Yury Norov wrote:
> > > 

> > > I don't understand what patch #4 is doing in this series. At the
> > > first
> > > glance, it may be applied separately.
> > 
> > It fixes test failures found by patch 2 in the series.
> > The idea is similar to TDD.
> 
> So with current order, patch 2 introduces regression that is fixed in
> patch 4, is my understanding correct?

I'm sorry to ask, but do you call new test cases "a regression" for
real?!

> This is not the best idea because it will break bisectability.

Huh?

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy