Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934173AbeAKMma (ORCPT + 1 other); Thu, 11 Jan 2018 07:42:30 -0500 Received: from mail-yb0-f193.google.com ([209.85.213.193]:39298 "EHLO mail-yb0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932361AbeAKMm2 (ORCPT ); Thu, 11 Jan 2018 07:42:28 -0500 X-Google-Smtp-Source: ACJfBovVZv8Bh5Ja7YahuRSDFcAK/ih30Jdzk0qnq2REvvs1XWIBMq5JorDS0OyUcJWeUqzLiV5HBA== Date: Thu, 11 Jan 2018 07:42:20 -0500 From: William Breathitt Gray To: Linus Walleij Cc: Arnd Bergmann , Guenter Roeck , "Maciej S . Szmigiero" , Andy Shevchenko , linux-gpio@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] gpio: winbond: fix ISA_BUS_API dependency Message-ID: <20180111124220.GA23490@sophia> References: <20180111083600.4121805-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Thu, Jan 11, 2018 at 10:18:56AM +0100, Linus Walleij wrote: >On Thu, Jan 11, 2018 at 9:35 AM, Arnd Bergmann wrote: > >> The newly added GPIO driver for winbond chipsets causes a >> circular dependency warning in Kconfig: >> >> drivers/gpio/Kconfig:13:error: recursive dependency detected! >> drivers/gpio/Kconfig:13: symbol GPIOLIB is selected by STX104 >> drivers/iio/adc/Kconfig:699: symbol STX104 depends on ISA_BUS_API >> arch/Kconfig:830: symbol ISA_BUS_API is selected by GPIO_WINBOND >> drivers/gpio/Kconfig:701: symbol GPIO_WINBOND depends on GPIOLIB >> >> The underlying problem is that ISA_BUS_API is not meant to be selected by >> device drivers, instead it is provided by the architectures that support >> ISA add-on card devices, or in case of x86 have this explicitly enabled. >> >> This particular driver appears to be different from the other ISA_BUS_API >> based drivers, in that it is not normally an add-on card (ISA or PC104) >> but instead is an LPC-attached component on the mainboard. We already >> support other functionality provided by this chip, at least >> drivers/watchdog/w83627hf_wdt.c and drivers/hwmon/w83627ehf.c, plus >> there is a discovery function for this hardware in >> drivers/parport/parport_pc.c. >> >> If we want to use this driver without having to enable CONFIG_EXPERT, >> it might be better to not use the isa_bus_type for it, but rather >> turn it into a platform_driver, acpi_driver or add an MFD for it that >> is shared with the wdt and hwmon portions and does the probing. >> >> For now, this patch fixes the dependency by changing 'select' into >> 'depends on'. >> >> Cc: William Breathitt Gray >> Cc: Guenter Roeck >> Cc: Maciej S. Szmigiero >> Cc: Andy Shevchenko >> Fixes: a0d65009411c ("gpio: winbond: Add driver") >> Signed-off-by: Arnd Bergmann > >I've tentatively applied this patch so we don't break the builds. > >We had a bunch of discussion about this already ... I guess we >need to go at it again, waiting for comments from Maciej and >William. > >Yours, >Linus Walleij Hi Linus, I don't believe this patch is necessary if you pull in the "Change ISA_BUS_API dependency to selection" patchset (https://patchwork.ozlabs.org/project/linux-gpio/list/?series=20657) as it has the proper fix for this recursive dependency. William Breathitt Gray