Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934054AbeAKNif (ORCPT + 1 other); Thu, 11 Jan 2018 08:38:35 -0500 Received: from verein.lst.de ([213.95.11.211]:52653 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932693AbeAKNie (ORCPT ); Thu, 11 Jan 2018 08:38:34 -0500 Date: Thu, 11 Jan 2018 14:38:32 +0100 From: Christoph Hellwig To: Jeff Moyer Cc: Christoph Hellwig , viro@zeniv.linux.org.uk, Avi Kivity , linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 26/32] aio: refactor read/write iocb setup Message-ID: <20180111133832.GA5854@lst.de> References: <20180110155853.32348-1-hch@lst.de> <20180110155853.32348-27-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, Jan 10, 2018 at 04:19:53PM -0500, Jeff Moyer wrote: > > +static int aio_prep_rw(struct kiocb *req, struct iocb *iocb) > > +{ > > + int ret; > > + > > + req->ki_filp = fget(iocb->aio_fildes); > > + if (unlikely(!req->ki_filp)) > > + return -EBADF; > > + req->ki_complete = aio_complete_rw; > > + req->ki_flags = 0; > > The above assignment seems superfluous... Thanks, fixed.