Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933094AbeAKNwL (ORCPT + 1 other); Thu, 11 Jan 2018 08:52:11 -0500 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:57554 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932913AbeAKNwH (ORCPT ); Thu, 11 Jan 2018 08:52:07 -0500 From: Philippe CORNU To: Brian Norris , Archit Taneja , Andrzej Hajda , "Laurent Pinchart" CC: David Airlie , Yannick FERTRE , Vincent ABRIOU , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Sean Paul , "Nickey Yang" , "hl@rock-chips.com" , "linux-rockchip@lists.infradead.org" , "mka@chromium.org" , "hoegsberg@gmail.com" , "zyw@rock-chips.com" , "xbl@rock-chips.com" Subject: Re: [PATCH v2 1/2] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet() Thread-Topic: [PATCH v2 1/2] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet() Thread-Index: AQHTiYkP4b5PRk6H9Emo1cg+dHCMLKNuor8A Date: Thu, 11 Jan 2018 13:51:35 +0000 Message-ID: References: <20180109203248.139249-1-briannorris@chromium.org> In-Reply-To: <20180109203248.139249-1-briannorris@chromium.org> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.47] Content-Type: text/plain; charset="utf-8" Content-ID: <7E988B0C851489488CC20F2650FCBA4A@st.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-11_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: SGkgQnJpYW4gJiBBbGwgKkRTSSBEUk0gZXhwZXJ0cyosDQoNCjEpIFJlLXJlYWRpbmcgdGhpcyBw YXRjaCwgSSByZWFsaXplIHRoYXQgdGhlIHJldHVybmVkIHZhbHVlIG9mIA0KZHdfbWlwaV9kc2lf aG9zdF90cmFuc2ZlcigpIGlzIG5vdCBjb3JyZWN0OiB3ZSBzaG91bGQgcmV0dXJuIHRoZSBudW1i ZXIgDQpvZiB0cmFuc2ZlcmVkL3JlY2VpdmVkIGJ5dGVzLi4uDQoNCnNvIEkgdGhpbmsgdGhlcmUg YXJlIHR3byBzb2x1dGlvbnM6IGZpeCB0aGlzIGluIHRoaXMgc2VyaWUgb3IgYWRkIGEgVE9ETyAN CmZvciBsYXRlciAoYm90aCBzb2x1dGlvbnMgYXJlIGZpbmUgdG8gbWUgOi0pDQoNCg0KMikgRGln Z2luZyBtb3JlIGludG8gdGhlIGRybSBjb2RlLCB0aGUgZnVuY3Rpb24gDQptaXBpX2RzaV9kZXZp Y2VfdHJhbnNmZXIoKSBpbiBkcm1fbWlwaV9kc2kuYyBpcyBjYWxsZWQgaW4gdGhlIHNhbWUgZmls ZSANCmJ5IHRoZSAzIGZvbGxvd2luZyBmdW5jdGlvbnM6IG1pcGlfZHNpX3NodXRkb3duX3Blcmlw aGVyYWwoKSwgDQptaXBpX2RzaV90dXJuX29uX3BlcmlwaGVyYWwoKSAmIA0KbWlwaV9kc2lfc2V0 X21heGltdW1fcmV0dXJuX3BhY2tldF9zaXplKCkuIEFsbCB0aGVzZSAzIGZ1bmN0aW9ucyBhcmUg DQpleHBlY3RpbmcgIlJldHVybjogMCBvbiBzdWNjZXNzIG9yIGEgbmVnYXRpdmUgZXJyb3IgY29k ZSBvbiBmYWlsdXJlLiIgDQp0aGF0IGlzIG5vdCBpbiBsaW5lIHdpdGggdGhlIHRyYW5zZmVyIGZ1 bmN0aW9uLg0KDQpTbyB0aGVuLCB3ZSBjYW4gY2hhbmdlIHRoZSBkb2N1bWVudGF0aW9uIGluIHRo aXMgZmlsZSBhbmQgaGF2ZSBpbnN0ZWFkIA0KIiogUmV0dXJuOiBUaGUgbnVtYmVyIG9mIGJ5dGVz IHRyYW5zbWl0dGVkIG9uIHN1Y2Nlc3Mgb3IgYSBuZWdhdGl2ZSANCmVycm9yIGNvZGUgb24gZmFp bHVyZS4iIGFzIGZvciBtaXBpX2RzaV9nZW5lcmljX3dyaXRlKCkuLi4NCk9yIHdlIGNhbiBjaGFu Z2UgdGhlIHNvdXJjZSBjb2RlIG9mIHRoZXNlIDMgZnVuY3Rpb25zIHRvIG1hdGNoIHdpdGggdGhl IA0KZG9jdW1lbnRhdGlvbiAiUmV0dXJuOiAwIG9uIHN1Y2Nlc3MuLi4iLg0KDQpub3RlOiBIb3Bl ZnVsbHksICJ1c2VycyIgb2YgdGhlc2UgMyBmdW5jdGlvbnMgdGVzdCB0aGUgc2lnbiBvZiB0aGUg DQpyZXR1cm4gdmFsdWUgKG9yIGRvIG5vdCB1c2UgaXQpLg0KDQpEb2VzIGFueW9uZSBoYXZlIGEg cHJlZmVycmVkIHNvbHV0aW9ucz8NCg0KTWFueSB0aGFua3MNClBoaWxpcHBlIDotKQ0KDQpPbiAw MS8wOS8yMDE4IDA5OjMyIFBNLCBCcmlhbiBOb3JyaXMgd3JvdGU6DQo+IFRoaXMgdGFrZXMgY2Fy ZSBvZiAyIFRPRE9zIGluIHRoaXMgZHJpdmVyLCBieSB1c2luZyB0aGUgY29tbW9uIERTSQ0KPiBw YWNrZXQtbWFyc2hhbGxpbmcgY29kZSBpbnN0ZWFkIG9mIG91ciBjdXN0b20gc2hvcnQvbG9uZyB3 cml0ZSBjb2RlLg0KPiBUaGlzIGJvdGggc2F2ZXMgdXMgc29tZSBkdXBsaWNhdGVkIGNvZGUgYW5k IGdldHMgdXMgZnJlZSBzdXBwb3J0IGZvcg0KPiBjb21tYW5kIHR5cGVzIHRoYXQgd2VyZW4ndCBh bHJlYWR5IHBhcnQgb2Ygb3VyIHN3aXRjaCBibG9jayAoZS5nLiwNCj4gTUlQSV9EU0lfR0VORVJJ Q19MT05HX1dSSVRFKS4NCj4gDQo+IFRoZSBjb2RlIGxvZ2ljIHN0YXlzIG1vc3RseSBpbnRhY3Qs IGV4Y2VwdCB0aGF0IGl0IGJlY29tZXMgdW5uZWNlc3NhcnkNCj4gdG8gc3BsaXQgdGhlIHNob3J0 L2xvbmcgd3JpdGUgZnVuY3Rpb25zLCBhbmQgd2UgaGF2ZSB0byBjb3B5IGRhdGEgYSBiaXQNCj4g bW9yZS4NCj4gDQo+IEFsb25nIHRoZSB3YXksIEkgbm90aWNlZCB0aGF0IGxvb3AgYm91bmRzIHdl cmUgYSBsaXR0bGUgb2RkOg0KPiANCj4gCXdoaWxlIChESVZfUk9VTkRfVVAobGVuLCBwbGRfZGF0 YV9ieXRlcykpDQo+IA0KPiBUaGlzIHJlYWxseSB3YXMganVzdCBzdXBwb3NlZCB0byBiZSAnbGVu ICE9IDAnLCBzbyBJIG1hZGUgdGhhdCBtb3JlDQo+IGNsZWFyLg0KPiANCj4gVGVzdGVkIG9uIFJL MzM5OSB3aXRoIHNvbWUgcGVuZGluZyByZWZhY3RvcmluZyBwYXRjaGVzIGJ5IE5pY2tleSBZYW5n LA0KPiB0byBtYWtlIHRoZSBSb2NrY2hpcCBEU0kgZHJpdmVyIHdyYXAgdGhpcyBjb21tb24gZHJp dmVyLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogQnJpYW4gTm9ycmlzIDxicmlhbm5vcnJpc0BjaHJv bWl1bS5vcmc+DQo+IFJldmlld2VkLWJ5OiBQaGlsaXBwZSBDb3JudSA8cGhpbGlwcGUuY29ybnVA c3QuY29tPg0KPiBUZXN0ZWQtYnk6IFBoaWxpcHBlIENvcm51IDxwaGlsaXBwZS5jb3JudUBzdC5j b20+DQo+IC0tLQ0KPiB2MjoNCj4gICAqIHJlbW92ZSAiZGNzIiBuYW1pbmcsIHNpbmNlIHRoZXNl IGNvbW1hbmRzIGhhbmRsZSBnZW5lcmljIERTSSB0b28sIG5vdA0KPiAgICAganVzdCBEQ1MgKHRo YW5rcyBQaGlsaXBwZSkNCj4gICAqIGFkZCBQaGlsaXBwZSdzIHtUZXN0ZWQsUmV2aWV3ZWR9LWJ5 DQo+IC0tLQ0KPiAgIGRyaXZlcnMvZ3B1L2RybS9icmlkZ2Uvc3lub3BzeXMvZHctbWlwaS1kc2ku YyB8IDc4ICsrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAx NiBpbnNlcnRpb25zKCspLCA2MiBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vYnJpZGdlL3N5bm9wc3lzL2R3LW1pcGktZHNpLmMgYi9kcml2ZXJzL2dwdS9k cm0vYnJpZGdlL3N5bm9wc3lzL2R3LW1pcGktZHNpLmMNCj4gaW5kZXggZDljY2E0ZmQ2NmVjLi5l ZDkxZTMyZWU0M2EgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2Uvc3lub3Bz eXMvZHctbWlwaS1kc2kuYw0KPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3N5bm9wc3lz L2R3LW1pcGktZHNpLmMNCj4gQEAgLTEzNiwxMCArMTM2LDYgQEANCj4gICAJCQkJCSBHRU5fU1df MFBfVFhfTFApDQo+ICAgDQo+ICAgI2RlZmluZSBEU0lfR0VOX0hEUgkJCTB4NmMNCj4gLS8qIFRP RE8gVGhlc2UgMiBkZWZpbmVzIHdpbGwgYmUgcmV3b3JrZWQgdGhhbmtzIHRvIG1pcGlfZHNpX2Ny ZWF0ZV9wYWNrZXQoKSAqLw0KPiAtI2RlZmluZSBHRU5fSERBVEEoZGF0YSkJCQkoKChkYXRhKSAm IDB4ZmZmZikgPDwgOCkNCj4gLSNkZWZpbmUgR0VOX0hUWVBFKHR5cGUpCQkJKCgodHlwZSkgJiAw eGZmKSA8PCAwKQ0KPiAtDQo+ICAgI2RlZmluZSBEU0lfR0VOX1BMRF9EQVRBCQkweDcwDQo+ICAg DQo+ICAgI2RlZmluZSBEU0lfQ01EX1BLVF9TVEFUVVMJCTB4NzQNCj4gQEAgLTM1OSw0NCArMzU1 LDE1IEBAIHN0YXRpYyBpbnQgZHdfbWlwaV9kc2lfZ2VuX3BrdF9oZHJfd3JpdGUoc3RydWN0IGR3 X21pcGlfZHNpICpkc2ksIHUzMiBoZHJfdmFsKQ0KPiAgIAlyZXR1cm4gMDsNCj4gICB9DQo+ICAg DQo+IC1zdGF0aWMgaW50IGR3X21pcGlfZHNpX2Rjc19zaG9ydF93cml0ZShzdHJ1Y3QgZHdfbWlw aV9kc2kgKmRzaSwNCj4gLQkJCQkgICAgICAgY29uc3Qgc3RydWN0IG1pcGlfZHNpX21zZyAqbXNn KQ0KPiAtew0KPiAtCWNvbnN0IHU4ICp0eF9idWYgPSBtc2ctPnR4X2J1ZjsNCj4gLQl1MTYgZGF0 YSA9IDA7DQo+IC0JdTMyIHZhbDsNCj4gLQ0KPiAtCWlmIChtc2ctPnR4X2xlbiA+IDApDQo+IC0J CWRhdGEgfD0gdHhfYnVmWzBdOw0KPiAtCWlmIChtc2ctPnR4X2xlbiA+IDEpDQo+IC0JCWRhdGEg fD0gdHhfYnVmWzFdIDw8IDg7DQo+IC0NCj4gLQlpZiAobXNnLT50eF9sZW4gPiAyKSB7DQo+IC0J CWRldl9lcnIoZHNpLT5kZXYsICJ0b28gbG9uZyB0eCBidWYgbGVuZ3RoICV6dSBmb3Igc2hvcnQg d3JpdGVcbiIsDQo+IC0JCQltc2ctPnR4X2xlbik7DQo+IC0JCXJldHVybiAtRUlOVkFMOw0KPiAt CX0NCj4gLQ0KPiAtCXZhbCA9IEdFTl9IREFUQShkYXRhKSB8IEdFTl9IVFlQRShtc2ctPnR5cGUp Ow0KPiAtCXJldHVybiBkd19taXBpX2RzaV9nZW5fcGt0X2hkcl93cml0ZShkc2ksIHZhbCk7DQo+ IC19DQo+IC0NCj4gLXN0YXRpYyBpbnQgZHdfbWlwaV9kc2lfZGNzX2xvbmdfd3JpdGUoc3RydWN0 IGR3X21pcGlfZHNpICpkc2ksDQo+IC0JCQkJICAgICAgY29uc3Qgc3RydWN0IG1pcGlfZHNpX21z ZyAqbXNnKQ0KPiArc3RhdGljIGludCBkd19taXBpX2RzaV93cml0ZShzdHJ1Y3QgZHdfbWlwaV9k c2kgKmRzaSwNCj4gKwkJCSAgICAgY29uc3Qgc3RydWN0IG1pcGlfZHNpX3BhY2tldCAqcGFja2V0 KQ0KPiAgIHsNCj4gLQljb25zdCB1OCAqdHhfYnVmID0gbXNnLT50eF9idWY7DQo+IC0JaW50IGxl biA9IG1zZy0+dHhfbGVuLCBwbGRfZGF0YV9ieXRlcyA9IHNpemVvZih1MzIpLCByZXQ7DQo+IC0J dTMyIGhkcl92YWwgPSBHRU5fSERBVEEobXNnLT50eF9sZW4pIHwgR0VOX0hUWVBFKG1zZy0+dHlw ZSk7DQo+ICsJY29uc3QgdTggKnR4X2J1ZiA9IHBhY2tldC0+cGF5bG9hZDsNCj4gKwlpbnQgbGVu ID0gcGFja2V0LT5wYXlsb2FkX2xlbmd0aCwgcGxkX2RhdGFfYnl0ZXMgPSBzaXplb2YodTMyKSwg cmV0Ow0KPiAgIAl1MzIgcmVtYWluZGVyOw0KPiAgIAl1MzIgdmFsOw0KPiAgIA0KPiAtCWlmICht c2ctPnR4X2xlbiA8IDMpIHsNCj4gLQkJZGV2X2Vycihkc2ktPmRldiwgIndyb25nIHR4IGJ1ZiBs ZW5ndGggJXp1IGZvciBsb25nIHdyaXRlXG4iLA0KPiAtCQkJbXNnLT50eF9sZW4pOw0KPiAtCQly ZXR1cm4gLUVJTlZBTDsNCj4gLQl9DQo+IC0NCj4gLQl3aGlsZSAoRElWX1JPVU5EX1VQKGxlbiwg cGxkX2RhdGFfYnl0ZXMpKSB7DQo+ICsJd2hpbGUgKGxlbikgew0KPiAgIAkJaWYgKGxlbiA8IHBs ZF9kYXRhX2J5dGVzKSB7DQo+ICAgCQkJcmVtYWluZGVyID0gMDsNCj4gICAJCQltZW1jcHkoJnJl bWFpbmRlciwgdHhfYnVmLCBsZW4pOw0KPiBAQCAtNDE5LDQwICszODYsMjcgQEAgc3RhdGljIGlu dCBkd19taXBpX2RzaV9kY3NfbG9uZ193cml0ZShzdHJ1Y3QgZHdfbWlwaV9kc2kgKmRzaSwNCj4g ICAJCX0NCj4gICAJfQ0KPiAgIA0KPiAtCXJldHVybiBkd19taXBpX2RzaV9nZW5fcGt0X2hkcl93 cml0ZShkc2ksIGhkcl92YWwpOw0KPiArCXJlbWFpbmRlciA9IDA7DQo+ICsJbWVtY3B5KCZyZW1h aW5kZXIsIHBhY2tldC0+aGVhZGVyLCBzaXplb2YocGFja2V0LT5oZWFkZXIpKTsNCj4gKwlyZXR1 cm4gZHdfbWlwaV9kc2lfZ2VuX3BrdF9oZHJfd3JpdGUoZHNpLCByZW1haW5kZXIpOw0KPiAgIH0N Cj4gICANCj4gICBzdGF0aWMgc3NpemVfdCBkd19taXBpX2RzaV9ob3N0X3RyYW5zZmVyKHN0cnVj dCBtaXBpX2RzaV9ob3N0ICpob3N0LA0KPiAgIAkJCQkJIGNvbnN0IHN0cnVjdCBtaXBpX2RzaV9t c2cgKm1zZykNCj4gICB7DQo+ICAgCXN0cnVjdCBkd19taXBpX2RzaSAqZHNpID0gaG9zdF90b19k c2koaG9zdCk7DQo+ICsJc3RydWN0IG1pcGlfZHNpX3BhY2tldCBwYWNrZXQ7DQo+ICAgCWludCBy ZXQ7DQo+ICAgDQo+IC0JLyoNCj4gLQkgKiBUT0RPIGR3IGRydiBpbXByb3ZlbWVudHMNCj4gLQkg KiB1c2UgbWlwaV9kc2lfY3JlYXRlX3BhY2tldCgpIGluc3RlYWQgb2YgYWxsIGZvbGxvd2luZw0K PiAtCSAqIGZ1bmN0aW9ucyBhbmQgY29kZSAobm8gc3dpdGNoIGNhc2VzLCBubw0KPiAtCSAqIGR3 X21pcGlfZHNpX2Rjc19zaG9ydF93cml0ZSgpLCBvbmx5IHRoZSBsb29wIGluIGxvbmdfd3JpdGUu Li4pDQo+IC0JICogYW5kIHVzZSBwYWNrZXQuaGVhZGVyLi4uDQo+IC0JICovDQo+IC0JZHdfbWlw aV9tZXNzYWdlX2NvbmZpZyhkc2ksIG1zZyk7DQo+IC0NCj4gLQlzd2l0Y2ggKG1zZy0+dHlwZSkg ew0KPiAtCWNhc2UgTUlQSV9EU0lfRENTX1NIT1JUX1dSSVRFOg0KPiAtCWNhc2UgTUlQSV9EU0lf RENTX1NIT1JUX1dSSVRFX1BBUkFNOg0KPiAtCWNhc2UgTUlQSV9EU0lfU0VUX01BWElNVU1fUkVU VVJOX1BBQ0tFVF9TSVpFOg0KPiAtCQlyZXQgPSBkd19taXBpX2RzaV9kY3Nfc2hvcnRfd3JpdGUo ZHNpLCBtc2cpOw0KPiAtCQlicmVhazsNCj4gLQljYXNlIE1JUElfRFNJX0RDU19MT05HX1dSSVRF Og0KPiAtCQlyZXQgPSBkd19taXBpX2RzaV9kY3NfbG9uZ193cml0ZShkc2ksIG1zZyk7DQo+IC0J CWJyZWFrOw0KPiAtCWRlZmF1bHQ6DQo+IC0JCWRldl9lcnIoZHNpLT5kZXYsICJ1bnN1cHBvcnRl ZCBtZXNzYWdlIHR5cGUgMHglMDJ4XG4iLA0KPiAtCQkJbXNnLT50eXBlKTsNCj4gLQkJcmV0ID0g LUVJTlZBTDsNCj4gKwlyZXQgPSBtaXBpX2RzaV9jcmVhdGVfcGFja2V0KCZwYWNrZXQsIG1zZyk7 DQo+ICsJaWYgKHJldCkgew0KPiArCQlkZXZfZXJyKGRzaS0+ZGV2LCAiZmFpbGVkIHRvIGNyZWF0 ZSBwYWNrZXQ6ICVkXG4iLCByZXQpOw0KPiArCQlyZXR1cm4gcmV0Ow0KPiAgIAl9DQo+ICAgDQo+ IC0JcmV0dXJuIHJldDsNCj4gKwlkd19taXBpX21lc3NhZ2VfY29uZmlnKGRzaSwgbXNnKTsNCj4g Kw0KPiArCXJldHVybiBkd19taXBpX2RzaV93cml0ZShkc2ksICZwYWNrZXQpOw0KPiAgIH0NCj4g ICANCj4gICBzdGF0aWMgY29uc3Qgc3RydWN0IG1pcGlfZHNpX2hvc3Rfb3BzIGR3X21pcGlfZHNp X2hvc3Rfb3BzID0gew0KPiA=