Date: Thu, 11 Jan 2018 23:12:51 +0900
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Mikael Starvik <starvik@axis.com>,
        Jesper Nilsson <jesper.nilsson@axis.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>, linux-cris-kernel@axis.com,
        linux-kernel@vger.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH] cris: Fix conflicting types for _etext, _edata, _end
Message-ID: <20180111141251.GA754@tigerII.localdomain>
References: <20180105024744.17037-1-sergey.senozhatsky@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180105024744.17037-1-sergey.senozhatsky@gmail.com>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org

On (01/05/18 11:47), Sergey Senozhatsky wrote:
> Include asm/sections.h header which contains the correct
> types for _etext, _edata and _end - char arrays.
> 
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

Mikael, Jesper,

any opinions?

	-ss

> ---
>  arch/cris/kernel/setup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/cris/kernel/setup.c b/arch/cris/kernel/setup.c
> index 524d47501a23..1b61a7207afb 100644
> --- a/arch/cris/kernel/setup.c
> +++ b/arch/cris/kernel/setup.c
> @@ -24,6 +24,7 @@
>  #include <linux/of_fdt.h>
>  #include <asm/setup.h>
>  #include <arch/system.h>
> +#include <asm/sections.h>
>  
>  /*
>   * Setup options
> @@ -31,7 +32,6 @@
>  struct screen_info screen_info;
>  
>  extern int root_mountflags;
> -extern char _etext, _edata, _end;
>  
>  char __initdata cris_command_line[COMMAND_LINE_SIZE] = { 0, };
>  
> -- 
> 2.15.1
>