Date: Thu, 11 Jan 2018 16:06:45 +0100
From: Jan Kara <jack@suse.cz>
To: Rakesh Pandit <rakesh@tuxera.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] vfs: remove unused argument in iterate_bdevs
Message-ID: <20180111150645.wqiz4zpklabriymh@quack2.suse.cz>
References: <20180111140406.GA10714@dhcp-108-107.ws.tuxera.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180111140406.GA10714@dhcp-108-107.ws.tuxera.com>
User-Agent: NeoMutt/20170421 (1.8.2)
Sender: linux-kernel-owner@vger.kernel.org

On Thu 11-01-18 16:04:07, Rakesh Pandit wrote:
> @@ -2472,7 +2472,7 @@ static inline int thaw_bdev(struct block_device *bdev, struct super_block *sb)
>  	return 0;
>  }
>  
> -static inline void iterate_bdevs(void (*f)(struct block_device *, void *), void *arg)
> +static inline void iterate_bdevs(void (*f)(struct block_device *, void *))

You've missed the void * in (*f) prototype here. Other than that:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR