Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933684AbeAKPSO (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Thu, 11 Jan 2018 10:18:14 -0500
Received: from mx1.mpynet.fi ([82.197.21.84]:43216 "EHLO mx1.mpynet.fi"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754517AbeAKPSN (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 11 Jan 2018 10:18:13 -0500
Date: Thu, 11 Jan 2018 17:18:11 +0200
From: Rakesh Pandit <rakesh@tuxera.com>
To: Jan Kara <jack@suse.cz>
CC: <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        "Alexander Viro" <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] vfs: remove unused argument in iterate_bdevs
Message-ID: <20180111151811.GA11277@dhcp-108-107.ws.tuxera.com>
References: <20180111140406.GA10714@dhcp-108-107.ws.tuxera.com>
 <20180111150645.wqiz4zpklabriymh@quack2.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20180111150645.wqiz4zpklabriymh@quack2.suse.cz>
User-Agent: Mutt/1.7.1 (2016-10-04)
X-ClientProxiedBy: tuxera-exch.ad.tuxera.com (10.20.48.11) To
 tuxera-exch.ad.tuxera.com (10.20.48.11)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Thu, Jan 11, 2018 at 04:06:45PM +0100, Jan Kara wrote:
> On Thu 11-01-18 16:04:07, Rakesh Pandit wrote:
> > @@ -2472,7 +2472,7 @@ static inline int thaw_bdev(struct block_device *bdev, struct super_block *sb)
> >  	return 0;
> >  }
> >  
> > -static inline void iterate_bdevs(void (*f)(struct block_device *, void *), void *arg)
> > +static inline void iterate_bdevs(void (*f)(struct block_device *, void *))
> 
> You've missed the void * in (*f) prototype here. Other than that:
> 
> Reviewed-by: Jan Kara <jack@suse.cz>

Thanks for catching it.  I would repost with your tag and fix it same time.