Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965027AbeAKPbe (ORCPT + 1 other); Thu, 11 Jan 2018 10:31:34 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:56582 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933272AbeAKPbd (ORCPT ); Thu, 11 Jan 2018 10:31:33 -0500 Date: Thu, 11 Jan 2018 15:31:31 +0000 From: Al Viro To: Rakesh Pandit Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara Subject: Re: [PATCH] vfs: remove unused argument in iterate_bdevs Message-ID: <20180111153131.GK13338@ZenIV.linux.org.uk> References: <20180111140406.GA10714@dhcp-108-107.ws.tuxera.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180111140406.GA10714@dhcp-108-107.ws.tuxera.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Thu, Jan 11, 2018 at 04:04:07PM +0200, Rakesh Pandit wrote: > Signed-off-by: Rakesh Pandit > --- > fs/block_dev.c | 4 ++-- > fs/sync.c | 12 ++++++------ > include/linux/fs.h | 4 ++-- > 3 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/fs/block_dev.c b/fs/block_dev.c > index 4a181fc..95eba30 100644 > --- a/fs/block_dev.c > +++ b/fs/block_dev.c > @@ -2112,7 +2112,7 @@ int __invalidate_device(struct block_device *bdev, bool kill_dirty) > } > EXPORT_SYMBOL(__invalidate_device); > > -void iterate_bdevs(void (*func)(struct block_device *, void *), void *arg) > +void iterate_bdevs(void (*func)(struct block_device *)) Sure, after you implement partially applied functions in C, so that we could do it properly. Until then - NAK.