Date: Thu, 11 Jan 2018 17:04:21 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Tim Chen <tim.c.chen@linux.intel.com>
cc: Andy Lutomirski <luto@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Greg KH <gregkh@linuxfoundation.org>,
        Dave Hansen <dave.hansen@intel.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Andi Kleen <ak@linux.intel.com>,
        Arjan Van De Ven <arjan.van.de.ven@intel.com>,
        David Woodhouse <dwmw@amazon.co.uk>,
        Peter Zijlstra <peterz@infradead.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Ashok Raj <ashok.raj@intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/5] x86/enter: Create macros to set/clear IBRS
In-Reply-To: <3aab341725ee6a9aafd3141387453b45d788d61a.1515542293.git.tim.c.chen@linux.intel.com>
Message-ID: <alpine.DEB.2.20.1801111639290.2091@nanos>
References: <cover.1515542293.git.tim.c.chen@linux.intel.com> <3aab341725ee6a9aafd3141387453b45d788d61a.1515542293.git.tim.c.chen@linux.intel.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org

On Tue, 9 Jan 2018, Tim Chen wrote:
> +
> +.macro WRMSR_ASM msr_nr:req edx_val:req eax_val:req
> +	movl	\msr_nr, %ecx
> +	movl	\edx_val, %edx
> +	movl	\eax_val, %eax
> +.endm

This is the most brilliant piece of useless code I've seen in a long time.


	 tglx