Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965088AbeAKQgv convert rfc822-to-8bit (ORCPT + 1 other); Thu, 11 Jan 2018 11:36:51 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:55558 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965028AbeAKQgt (ORCPT ); Thu, 11 Jan 2018 11:36:49 -0500 Date: Thu, 11 Jan 2018 17:36:29 +0100 From: Thomas Petazzoni To: David Miller Cc: antoine.tenart@free-electrons.com, kishon@ti.com, andrew@lunn.ch, gregory.clement@free-electrons.com, linux@armlinux.org.uk, mw@semihalf.com, stefanc@marvell.com, ymarkman@marvell.com, miquel.raynal@free-electrons.com, nadavh@marvell.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v4 0/4] net: mvpp2: 1000BaseX and 2500BaseX support Message-ID: <20180111173629.5d682190@windsurf.lan> In-Reply-To: <20180111.113203.1899608306187914852.davem@davemloft.net> References: <20180110155808.3484-1-antoine.tenart@free-electrons.com> <20180111.112337.98385023847631863.davem@davemloft.net> <20180111.113203.1899608306187914852.davem@davemloft.net> Organization: Free Electrons X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hello, On Thu, 11 Jan 2018 11:32:03 -0500 (EST), David Miller wrote: > From: David Miller > Date: Thu, 11 Jan 2018 11:23:37 -0500 (EST) > > > From: Antoine Tenart > > Date: Wed, 10 Jan 2018 16:58:04 +0100 > > > >> This series adds 1000BaseX and 2500BaseX support to the Marvell PPv2 > >> driver. In order to use it, the 2.5 SGMII mode is added in the Marvell > >> common PHY driver (cp110-comphy). > > > > Series applied, thank you. > > Actually, this introduced build warnings, I'm reverting. Please fix this > and repost. > > Thank you. > > drivers/net/ethernet/marvell/mvpp2.c: In function ‘mvpp2_port_mii_gmac_configure_mode’: > drivers/net/ethernet/marvell/mvpp2.c:4687:26: warning: suggest parentheses around comparison in operand of ‘|’ [-Wparentheses] > if (port->phy_interface == PHY_INTERFACE_MODE_1000BASEX | > ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ This is actually a very good warning: it should be a || and not |. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com