Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935564AbeAKSDz (ORCPT + 1 other); Thu, 11 Jan 2018 13:03:55 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:47109 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932454AbeAKSDv (ORCPT ); Thu, 11 Jan 2018 13:03:51 -0500 X-ME-Sender: Subject: Re: [PATCH] tools/testing: Fix trailing semicolon To: shuah@kernel.org, linux-kernel@vger.kernel.org Cc: linux-kselftest@vger.kernel.org, Greg Kroah-Hartman , Thomas Gleixner , Kate Stewart , Joe Perches , Shuah Khan References: <20180111134607.12821-1-luisbg@kernel.org> From: Luis de Bethencourt Message-ID: <97f5465b-1c18-5e1d-d84c-ce542d420540@kernel.org> Date: Thu, 11 Jan 2018 18:03:49 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/11/2018 05:21 PM, Shuah Khan wrote: > On 01/11/2018 06:46 AM, Luis de Bethencourt wrote: >> The trailing semicolon is an empty statement that does no operation. >> Removing it since it doesn't do anything. >> >> Signed-off-by: Luis de Bethencourt >> --- >> >> Hi Shuah, >> >> After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches >> suggested I fix it treewide [0]. >> >> Best regards :) >> Luis >> >> >> [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html >> [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html >> >> tools/testing/selftests/nsfs/pidns.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/nsfs/pidns.c b/tools/testing/selftests/nsfs/pidns.c >> index 1182d4e437a2..e0d86e1668c0 100644 >> --- a/tools/testing/selftests/nsfs/pidns.c >> +++ b/tools/testing/selftests/nsfs/pidns.c >> @@ -70,7 +70,7 @@ int main(int argc, char *argv[]) >> return pr_err("NS_GET_PARENT returned a wrong namespace"); >> >> if (ioctl(pns, NS_GET_PARENT) >= 0 || errno != EPERM) >> - return pr_err("Don't get EPERM");; >> + return pr_err("Don't get EPERM"); >> } >> >> kill(pid, SIGKILL); >> > > Thanks for the patch. I will take this in for 4.16-rc1. > > thanks, > -- Shuah > Awesome. Thanks Shuah! Luis