Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935099AbeAKSNM (ORCPT + 1 other); Thu, 11 Jan 2018 13:13:12 -0500 Received: from imap.thunk.org ([74.207.234.97]:37470 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932215AbeAKSNK (ORCPT ); Thu, 11 Jan 2018 13:13:10 -0500 Date: Thu, 11 Jan 2018 13:13:07 -0500 From: Theodore Ts'o To: zhouzhouyi@gmail.com Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] FS: EXT4: syn error in __ext4_grp_locked_error Message-ID: <20180111181307.GC19241@thunk.org> Mail-Followup-To: Theodore Ts'o , zhouzhouyi@gmail.com, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org References: <1513305136-27652-1-git-send-email-zhouzhouyi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1513305136-27652-1-git-send-email-zhouzhouyi@gmail.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Fri, Dec 15, 2017 at 02:32:16AM +0000, zhouzhouyi@gmail.com wrote: > From: Zhouyi Zhou > > In function __ext4_grp_locked_error, __save_error_info > is called to save error info in super block block, but does not sync > that information to disk to info the subsequence fsck after reboot. > > This patch sync the error information to disk. After this patch, > I think there is no obvious EXT4 error handle branche which leads to > "Remounting filesystem read-only" will leave the disk partition miss > the subsequence fsck. > > Compiled in x86_64 Linux > Signed-off-by: Zhouyi Zhou Applied, thanks. - Ted