Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933039AbeAKURh (ORCPT + 1 other); Thu, 11 Jan 2018 15:17:37 -0500 Received: from mail-it0-f68.google.com ([209.85.214.68]:46745 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932437AbeAKURe (ORCPT ); Thu, 11 Jan 2018 15:17:34 -0500 X-Google-Smtp-Source: ACJfBosd9j0W6d1p5Wq+NRfyZmAkcH0Pq9PBv2onTaHb+YbA1i3TOSjZelqW6q/rsupFEG20UYX1LiztHE27QzAiXaI= MIME-Version: 1.0 In-Reply-To: <20180111201006.GA29756@kroah.com> References: <20180105204557.GA8839@kroah.com> <20180107104540.GB14783@kroah.com> <20180108074645.GA24062@kroah.com> <20180111201006.GA29756@kroah.com> From: Linus Torvalds Date: Thu, 11 Jan 2018 12:17:31 -0800 X-Google-Sender-Auth: C7SfsY8DoNG6-zYPRz9J4ueAXJQ Message-ID: Subject: Re: [PATCH 4.4 00/37] 4.4.110-stable review To: Greg Kroah-Hartman Cc: Pavel Tatashin , Andy Lutomirski , Hugh Dickins , Thomas Voegtle , Linux Kernel Mailing List , Andrew Morton , Guenter Roeck , Shuah Khan , patches@kernelci.org, Ben Hutchings , lkft-triage@lists.linaro.org, stable , Steve Sistare Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Thu, Jan 11, 2018 at 12:10 PM, Greg Kroah-Hartman wrote: > > Nice, but why does this not show up in 4.9 and 4.14 and Linus's tree as > well on this hardware? Nor on the SLES12 SP3 kernel? > > What is different there that 4.4 requires? That worries me more than > your fix (which looks good to me, fwiw.) I really think it's simply that since v4.6, we've had commit 67a9108ed431 ("x86/efi: Build our own page table structures"), so no normal EFI use actually uses the old legacy mapping unless you passed in "efi=old_map" on the kernel command line. So the bug is there in all versions, it's just that it's normally only noticeable in 4.4. But I might be missing some other difference, so take that with a pinch of salt. Linus