Date: Thu, 11 Jan 2018 21:37:36 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
cc: Pavel Tatashin <pasha.tatashin@oracle.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andy Lutomirski <luto@kernel.org>,
        Hugh Dickins <hughd@google.com>, Thomas Voegtle <tv@lio96.de>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Guenter Roeck <linux@roeck-us.net>,
        Shuah Khan <shuahkh@osg.samsung.com>, patches@kernelci.org,
        Ben Hutchings <ben.hutchings@codethink.co.uk>,
        lkft-triage@lists.linaro.org, stable <stable@vger.kernel.org>,
        Steve Sistare <steven.sistare@oracle.com>,
        Matt Fleming <matt@codeblueprint.co.uk>,
        Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH 4.4 00/37] 4.4.110-stable review
In-Reply-To: <CA+55aFxji41K_MdLAKiZ7MaXNT4w=OV0yQiTvroJs0_jy6DUOw@mail.gmail.com>
Message-ID: <alpine.DEB.2.20.1801112105010.2091@nanos>
References: <20180105175229.GA29834@kroah.com> <CALCETrW3hfkeUAPzFhGdE56vn23Q462h2reMaT=3ftbNGeSb3Q@mail.gmail.com> <CAOAebxvbXrVV7-x6LdEsAEhjR=qrxNBxxBrWzk7RaBECcWqsiw@mail.gmail.com> <CAOAebxv47m34R1qteFaQB1-x4jsUVJPPvPLVe4jxRGZeFUY2qA@mail.gmail.com>
 <CAOAebxuqK4TOktLrHNLdW-S3oSxVO2og84js7N5u_QDC7mE2Ow@mail.gmail.com> <20180105204557.GA8839@kroah.com> <a93f30d1-e00e-419b-532d-203be16e2299@oracle.com> <20180107104540.GB14783@kroah.com> <CAOAebxsBVTyS2gSXh4c-g1b8Lvjv9MBG3Wjr_AC+LJpMLHRqEA@mail.gmail.com>
 <CAOAebxsP1LLV-Eg_h8brbxfsn_tpRDR46yrVZeokrFt3ArRuMA@mail.gmail.com> <20180108074645.GA24062@kroah.com> <CAOAebxu_gGE5chc-Mn=zBo_M3ojExvooNfvFRWOT=FygoffjLQ@mail.gmail.com> <CAOAebxuecMGOVe4zfNgk+t3mXVnDaWVA-GLdb+HiX3t9LNnxLg@mail.gmail.com>
 <CAOAebxu-OY-sxEZVzOkrG0iVG92ACiMNWk9xXVqZjj8kO5gp3A@mail.gmail.com> <CAOAebxtr6fg+_qpCpotgcWyfAzDZEczZ3SuGHQkRSEE3MKh8Mg@mail.gmail.com> <CA+55aFxji41K_MdLAKiZ7MaXNT4w=OV0yQiTvroJs0_jy6DUOw@mail.gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org

On Thu, 11 Jan 2018, Linus Torvalds wrote:

> [ Patch to make sure the EFI trampoline_pgd is properly aligned and
> has the double pgd that KPTI requires ]
> 
> On Thu, Jan 11, 2018 at 10:40 AM, Pavel Tatashin
> <pasha.tatashin@oracle.com> wrote:
> > If it is better to resubmit this patch via git send-email, please let me know.
> 
> It would be better, because that way the patch can be more easily
> quoted and discussed.
> 
> That said, I do not see why this isn't an issue upstream too.
> 
> As far as I can tell, it's not just 4.4.110. Our current entry code
> does that ADJUST_KERNEL_CR3 dance too, which clears the
> PTI_SWITCH_MASK bit from cr3.
> 
> And that realmode trampoline pgd seems all to be just aligned to PAGE_SIZE.

Right, but see below.

> Now, in the modern world, we generate new page tables for EFI, but we
> still have that EFI_OLD_MEMMAP code that disables that. And afaik,
> EFI_OLD_MEMMAP has the exact same problem that your patch fixes in 4.4
> (where it's always on).
> 
> So I think this patch should go into the development kernel too.
> 
> Or maybe it already is, and I just haven't gotten it yet.

It's not. There is an efi oldmap fix pending, but that's a different story.

> Or - even more likely - I'm missing something entirely, and even
> EFI_OLD_MEMMAP solved this some other way upstream.

67a9108ed431 ("x86/efi: Build our own page table structures")

got rid of EFI depending on real_mode_header->trampoline_pgd

So I don't see how upstream needs the fix as the trampoline_pgd seems only
to be used when coming out of the boot loader.

Adding Matt. He stepped back from EFI, but he might still know.

> Adding Thomas Gleixner explicitly to the participants so that he can
> tell me I'm a moron and point me to the right thing.

Your wish is my command, but I need to stare some more before doing so.

Thanks,

	tglx