MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1801112105010.2091@nanos>
References: <20180105175229.GA29834@kroah.com> <CALCETrW3hfkeUAPzFhGdE56vn23Q462h2reMaT=3ftbNGeSb3Q@mail.gmail.com>
 <CAOAebxvbXrVV7-x6LdEsAEhjR=qrxNBxxBrWzk7RaBECcWqsiw@mail.gmail.com>
 <CAOAebxv47m34R1qteFaQB1-x4jsUVJPPvPLVe4jxRGZeFUY2qA@mail.gmail.com>
 <CAOAebxuqK4TOktLrHNLdW-S3oSxVO2og84js7N5u_QDC7mE2Ow@mail.gmail.com>
 <20180105204557.GA8839@kroah.com> <a93f30d1-e00e-419b-532d-203be16e2299@oracle.com>
 <20180107104540.GB14783@kroah.com> <CAOAebxsBVTyS2gSXh4c-g1b8Lvjv9MBG3Wjr_AC+LJpMLHRqEA@mail.gmail.com>
 <CAOAebxsP1LLV-Eg_h8brbxfsn_tpRDR46yrVZeokrFt3ArRuMA@mail.gmail.com>
 <20180108074645.GA24062@kroah.com> <CAOAebxu_gGE5chc-Mn=zBo_M3ojExvooNfvFRWOT=FygoffjLQ@mail.gmail.com>
 <CAOAebxuecMGOVe4zfNgk+t3mXVnDaWVA-GLdb+HiX3t9LNnxLg@mail.gmail.com>
 <CAOAebxu-OY-sxEZVzOkrG0iVG92ACiMNWk9xXVqZjj8kO5gp3A@mail.gmail.com>
 <CAOAebxtr6fg+_qpCpotgcWyfAzDZEczZ3SuGHQkRSEE3MKh8Mg@mail.gmail.com>
 <CA+55aFxji41K_MdLAKiZ7MaXNT4w=OV0yQiTvroJs0_jy6DUOw@mail.gmail.com> <alpine.DEB.2.20.1801112105010.2091@nanos>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Thu, 11 Jan 2018 12:46:43 -0800
Message-ID: <CA+55aFxq5dsmeGaXxR55+P+P+6MDjUkEUWkLp8pb3j+GOFYxTw@mail.gmail.com>
Subject: Re: [PATCH 4.4 00/37] 4.4.110-stable review
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Pavel Tatashin <pasha.tatashin@oracle.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andy Lutomirski <luto@kernel.org>,
        Hugh Dickins <hughd@google.com>, Thomas Voegtle <tv@lio96.de>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Guenter Roeck <linux@roeck-us.net>,
        Shuah Khan <shuahkh@osg.samsung.com>, patches@kernelci.org,
        Ben Hutchings <ben.hutchings@codethink.co.uk>,
        lkft-triage@lists.linaro.org, stable <stable@vger.kernel.org>,
        Steve Sistare <steven.sistare@oracle.com>,
        Matt Fleming <matt@codeblueprint.co.uk>,
        Borislav Petkov <bp@alien8.de>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org

On Thu, Jan 11, 2018 at 12:37 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
>
> 67a9108ed431 ("x86/efi: Build our own page table structures")
>
> got rid of EFI depending on real_mode_header->trampoline_pgd

So I think it only got rid of by default - the codepath is still
there, the allocation is still there, it's just that it's not actually
used unless somebody does that "efi=old_mmap" thing.

Looking around, there's at least one quirk for the SGI UV1 system that
enables EFI_OLD_MMAP automatically. There might be others that I
missed, but I think that's it.

So it *can* trigger without "efi=old_mmap", but not on any normal machines.

And as Pavel points out, even when the bug is active, it's pretty hard
to actually trigger.

But yeah, there may be other EFI patches that I didn't notice that
changed things in other ways too.

               Linus