Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932938AbeAKU6V (ORCPT + 1 other); Thu, 11 Jan 2018 15:58:21 -0500 Received: from mail-vk0-f68.google.com ([209.85.213.68]:35497 "EHLO mail-vk0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752253AbeAKU6S (ORCPT ); Thu, 11 Jan 2018 15:58:18 -0500 X-Google-Smtp-Source: ACJfBotEZoCNjSFEfPOhQ7q5X6OUtTa9qVSDCaLyq2DyNNUZIIPUheA8j2BlvvCQzTegzSMb5cs4GKZYYDgZdrOswBY= MIME-Version: 1.0 In-Reply-To: References: <1515377863-20358-1-git-send-email-david@lechnology.com> <1515377863-20358-2-git-send-email-david@lechnology.com> <22409e49-5c14-4068-b137-7535afaf90d7@lechnology.com> <0f90b5f7-f21e-5f81-1154-9a815bbb786d@ti.com> <5aacc350-6236-2e4f-35bb-a681fc9d47e7@ti.com> <40501635-6f5b-20c9-f8bc-d17e26b58426@lechnology.com> From: Adam Ford Date: Thu, 11 Jan 2018 14:58:16 -0600 Message-ID: Subject: Re: [PATCH v5 01/44] dt-bindings: clock: Add new bindings for TI Davinci PLL clocks To: David Lechner Cc: Sekhar Nori , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Michael Turquette , Stephen Boyd , Rob Herring , Mark Rutland , Kevin Hilman , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Thu, Jan 11, 2018 at 2:04 PM, David Lechner wrote: > On 01/11/2018 12:50 PM, Adam Ford wrote: >> >> On Thu, Jan 11, 2018 at 12:29 PM, David Lechner >> wrote: >>> >>> If removing the "clk_ignore_unused" option causes the board to not boot, >>> then we still have problems that need to be fixed, so please also test >>> without this option. >> >> >> Without this option, it still does not boot. Without device tree it >> hangs after: >> >> [snip] >> >> NET: Registered protocol family 17 >> Loading compiled-in X.509 certificates >> console [netcon0] enabled >> netconsole: network logging started >> davinci_emac davinci_emac.1: using random MAC addr: 5e:38:1a:1f:4f:77 >> mmc0: host does not support reading read-only switch, assuming >> write-enable >> hctosys: unable to open rtc device (rtc0) >> mmc0: new high speed SDHC card at address b368 >> >> >> With device tree it hangs after: >> >> [snip] >> mmc0: host does not support reading read-only switch, assuming >> write-enable >> mmc0: new high speed SDHC card at address b368 >> mmcblk0: mmc0:b368 00000 3.75 GiB >> mmcblk0: p1 p2 >> pca953x 0-0020: 0-0020 supply vcc not found, using dummy regulator >> pca953x 0-0020: failed reading register >> pca953x: probe of 0-0020 failed with error -121 >> console [netcon0] enabled >> netconsole: network logging started >> davinci_emac 1e20000.ethernet: incompatible machine/device type for >> reading mac address >> hctosys: unable to open rtc device (rtc0) >> >> > > Please try this change: > > diff --git a/drivers/clk/davinci/psc-da850.c > b/drivers/clk/davinci/psc-da850.c > index 3fd6b49..a526cc2 100644 > --- a/drivers/clk/davinci/psc-da850.c > +++ b/drivers/clk/davinci/psc-da850.c > @@ -17,7 +17,7 @@ static const struct davinci_psc_clk_info da850_psc0_info[] > __initconst = { > LPSC(0, 0, tpcc0, pll0_sysclk2, LPSC_ALWAYS_ENABLED), > LPSC(1, 0, tptc0, pll0_sysclk2, LPSC_ALWAYS_ENABLED), > LPSC(2, 0, tptc1, pll0_sysclk2, LPSC_ALWAYS_ENABLED), > - LPSC(3, 0, aemif, pll0_sysclk3, 0), > + LPSC(3, 0, aemif, pll0_sysclk3, LPSC_ALWAYS_ENABLED), > LPSC(4, 0, spi0, pll0_sysclk2, 0), > LPSC(5, 0, mmcsd0, pll0_sysclk2, 0), > LPSC(6, 0, aintc, pll0_sysclk4, LPSC_ALWAYS_ENABLED), > > > > If that does not work, try adding LPSC_ALWAYS_ENABLED to all of the clocks > in this file and then eliminate them one by one until you find which one is > preventing boot. > Unfortunately, that didn't work. I switch all the entries in both tables that had a 0 to LPSC_ALWAYS_ENABLED, but no luck booting. > If it still does not boot, there is a similar DIVCLK_ALWAYS_ENABLED flag in > drivers/clk/davinci/pll-da850.c that you can repeat the exercise with. Add > DIVCLK_ALWAYS_ENABLED to all of the clocks there and then eliminate it one > by one until you find the clock that is causing the problem. Still no good news. I switched all the entries with a 0 to DIVCLK_ALWAYS_ENABLED and it still didn't finish booting. I wonder if Sekhar Nori might have some suggestions. I didn't look at the code or try to understand it. I just changed the settings. > adam