Subject: Re: [PATCH v2 0/7] pipe: buffer limits fixes and cleanups
To: linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
References: <20180111052902.14409-1-ebiggers3@gmail.com>
From: Joe Lawrence <joe.lawrence@redhat.com>
Organization: Red Hat
Message-ID: <93091f53-f1dd-8362-a5ad-5794892b63ad@redhat.com>
Date: Thu, 11 Jan 2018 16:41:12 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.0
MIME-Version: 1.0
In-Reply-To: <20180111052902.14409-1-ebiggers3@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On 01/11/2018 12:28 AM, Eric Biggers wrote:
> This series simplifies the sysctl handler for pipe-max-size and fixes
> another set of bugs related to the pipe buffer limits:
> 
> - The root user wasn't allowed to exceed the limits when creating new
>   pipes.
> 
> - There was an off-by-one error when checking the limits, so a limit of
>   N was actually treated as N - 1.
> 
> - F_SETPIPE_SZ accepted values over UINT_MAX.
> 
> - Reading the pipe buffer limits could be racy.
> 
> Changed since v1:
> 
>   - Added "Fixes" tag to "pipe: fix off-by-one error when checking buffer limits"
>   - In pipe_set_size(), checked 'nr_pages' rather than 'size'
>   - Fixed commit message for "pipe: simplify round_pipe_size()"
> 
> Eric Biggers (7):
>   pipe, sysctl: drop 'min' parameter from pipe-max-size converter
>   pipe, sysctl: remove pipe_proc_fn()
>   pipe: actually allow root to exceed the pipe buffer limits
>   pipe: fix off-by-one error when checking buffer limits
>   pipe: reject F_SETPIPE_SZ with size over UINT_MAX
>   pipe: simplify round_pipe_size()
>   pipe: read buffer limits atomically
> 
>  fs/pipe.c                 | 57 ++++++++++++++++++++---------------------------
>  include/linux/pipe_fs_i.h |  5 ++---
>  include/linux/sysctl.h    |  3 ---
>  kernel/sysctl.c           | 33 +++++----------------------
>  4 files changed, 32 insertions(+), 66 deletions(-)
> 

Bug fixes look good and thanks for continuing the code cleanup!

For the series:
Acked-by: Joe Lawrence <joe.lawrence@redhat.com>

-- Joe