Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933254AbeAKVqX (ORCPT + 1 other); Thu, 11 Jan 2018 16:46:23 -0500 Received: from vern.gendns.com ([206.190.152.46]:40160 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932472AbeAKVqU (ORCPT ); Thu, 11 Jan 2018 16:46:20 -0500 Subject: Re: [PATCH v5 01/44] dt-bindings: clock: Add new bindings for TI Davinci PLL clocks To: Adam Ford Cc: Sekhar Nori , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Michael Turquette , Stephen Boyd , Rob Herring , Mark Rutland , Kevin Hilman , linux-kernel@vger.kernel.org References: <1515377863-20358-1-git-send-email-david@lechnology.com> <22409e49-5c14-4068-b137-7535afaf90d7@lechnology.com> <0f90b5f7-f21e-5f81-1154-9a815bbb786d@ti.com> <5aacc350-6236-2e4f-35bb-a681fc9d47e7@ti.com> <40501635-6f5b-20c9-f8bc-d17e26b58426@lechnology.com> <5832fd62-16aa-e167-7e52-2ce493e33cdc@lechnology.com> From: David Lechner Message-ID: Date: Thu, 11 Jan 2018 15:46:19 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/11/2018 03:34 PM, Adam Ford wrote: > On Thu, Jan 11, 2018 at 3:04 PM, David Lechner wrote: >> On 01/11/2018 02:58 PM, Adam Ford wrote: >>> >>> On Thu, Jan 11, 2018 at 2:04 PM, David Lechner >>> wrote: >>>> >>>> On 01/11/2018 12:50 PM, Adam Ford wrote: >>>>> >>>>> >>>>> On Thu, Jan 11, 2018 at 12:29 PM, David Lechner >>>>> wrote: >>>>>> >>>>>> >>>>>> If removing the "clk_ignore_unused" option causes the board to not >>>>>> boot, >>>>>> then we still have problems that need to be fixed, so please also test >>>>>> without this option. >>>>> >>>>> >>>>> >>>>> Without this option, it still does not boot. Without device tree it >>>>> hangs after: >>>>> >>>>> [snip] >>>>> >>>>> NET: Registered protocol family 17 >>>>> Loading compiled-in X.509 certificates >>>>> console [netcon0] enabled >>>>> netconsole: network logging started >>>>> davinci_emac davinci_emac.1: using random MAC addr: 5e:38:1a:1f:4f:77 >>>>> mmc0: host does not support reading read-only switch, assuming >>>>> write-enable >>>>> hctosys: unable to open rtc device (rtc0) >>>>> mmc0: new high speed SDHC card at address b368 >>>>> >>>>> >>>>> With device tree it hangs after: >>>>> >>>>> [snip] >>>>> mmc0: host does not support reading read-only switch, assuming >>>>> write-enable >>>>> mmc0: new high speed SDHC card at address b368 >>>>> mmcblk0: mmc0:b368 00000 3.75 GiB >>>>> mmcblk0: p1 p2 >>>>> pca953x 0-0020: 0-0020 supply vcc not found, using dummy regulator >>>>> pca953x 0-0020: failed reading register >>>>> pca953x: probe of 0-0020 failed with error -121 >>>>> console [netcon0] enabled >>>>> netconsole: network logging started >>>>> davinci_emac 1e20000.ethernet: incompatible machine/device type for >>>>> reading mac address >>>>> hctosys: unable to open rtc device (rtc0) >>>>> >>>>> >>>> >>>> Please try this change: >>>> >>>> diff --git a/drivers/clk/davinci/psc-da850.c >>>> b/drivers/clk/davinci/psc-da850.c >>>> index 3fd6b49..a526cc2 100644 >>>> --- a/drivers/clk/davinci/psc-da850.c >>>> +++ b/drivers/clk/davinci/psc-da850.c >>>> @@ -17,7 +17,7 @@ static const struct davinci_psc_clk_info >>>> da850_psc0_info[] >>>> __initconst = { >>>> LPSC(0, 0, tpcc0, pll0_sysclk2, LPSC_ALWAYS_ENABLED), >>>> LPSC(1, 0, tptc0, pll0_sysclk2, LPSC_ALWAYS_ENABLED), >>>> LPSC(2, 0, tptc1, pll0_sysclk2, LPSC_ALWAYS_ENABLED), >>>> - LPSC(3, 0, aemif, pll0_sysclk3, 0), >>>> + LPSC(3, 0, aemif, pll0_sysclk3, LPSC_ALWAYS_ENABLED), >>>> LPSC(4, 0, spi0, pll0_sysclk2, 0), >>>> LPSC(5, 0, mmcsd0, pll0_sysclk2, 0), >>>> LPSC(6, 0, aintc, pll0_sysclk4, LPSC_ALWAYS_ENABLED), >>>> >>>> >>>> >>>> If that does not work, try adding LPSC_ALWAYS_ENABLED to all of the >>>> clocks >>>> in this file and then eliminate them one by one until you find which one >>>> is >>>> preventing boot. >>>> >>> Unfortunately, that didn't work. I switch all the entries in both >>> tables that had a 0 to LPSC_ALWAYS_ENABLED, but no luck booting. >>> >>>> If it still does not boot, there is a similar DIVCLK_ALWAYS_ENABLED flag >>>> in >>>> drivers/clk/davinci/pll-da850.c that you can repeat the exercise with. >>>> Add >>>> DIVCLK_ALWAYS_ENABLED to all of the clocks there and then eliminate it >>>> one >>>> by one until you find the clock that is causing the problem. >>> >>> >>> Still no good news. I switched all the entries with a 0 to >>> DIVCLK_ALWAYS_ENABLED and it still didn't finish booting. >>> >>> I wonder if Sekhar Nori might have some suggestions. I didn't look at >>> the code or try to understand it. I just changed the settings. >>>> >>>> >> >> Even if a clock had another flag besides zero, you will need to add >> LPSC_ALWAYS_ENABLED by or-ing it with the other flag. >> > > [snip] > > > Thanks for clarifying. I was able to make it work with the following patch: > > diff --git a/drivers/clk/davinci/psc-da850.c b/drivers/clk/davinci/psc-da850.c > index 3b4583d..a76b8682 100644 > --- a/drivers/clk/davinci/psc-da850.c > +++ b/drivers/clk/davinci/psc-da850.c > @@ -25,7 +25,7 @@ static const struct davinci_psc_clk_info > da850_psc0_info[] __initconst = { > LPSC(9, 0, uart0, pll0_sysclk2, 0), > LPSC(13, 0, pruss, pll0_sysclk2, 0), > LPSC(14, 0, arm, pll0_sysclk6, LPSC_ALWAYS_ENABLED), > - LPSC(15, 1, dsp, pll0_sysclk1, LPSC_FORCE | LPSC_LOCAL_RESET), > + LPSC(15, 1, dsp, pll0_sysclk1, LPSC_FORCE | LPSC_LOCAL_RESET | > LPSC_ALWAYS_ENABLED), > { } > }; > > > If you have an updated patch series with those two fixes, I add my > name to the tested-by list. > > >> >> > [snip] >> Great! Thanks again for testing. Sekhar, have you had a chance to look at the rest of the patches in the series? I'll wait a bit before I send a v6 to see if any other comments come.