Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932274AbeAKXM7 (ORCPT + 1 other); Thu, 11 Jan 2018 18:12:59 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:33755 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751968AbeAKXM6 (ORCPT ); Thu, 11 Jan 2018 18:12:58 -0500 Date: Fri, 12 Jan 2018 00:12:56 +0100 From: Alexandre Belloni To: Arnd Bergmann Cc: Alessandro Zummo , Patrick Bruenn , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: mxc_v2: remove __exit annotation Message-ID: <20180111231256.GC2678@piout.net> References: <20180102094443.3246258-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180102094443.3246258-1-arnd@arndb.de> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 02/01/2018 at 10:43:33 +0100, Arnd Bergmann wrote: > The mxc_rtc_remove is incorrectly annotated as __exit: > > `mxc_rtc_remove' referenced in section `.data' of drivers/rtc/rtc-mxc_v2.o: defined in discarded section `.exit.text' of drivers/rtc/rtc-mxc_v2.o > > This should not be done, as devices can be dynamically bound > and unbound to a driver. > > Fixes: 54c47014b474 ("rtc: add mxc driver for i.MX53 SRTC") > Signed-off-by: Arnd Bergmann > --- > drivers/rtc/rtc-mxc_v2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com