Message-ID: <5A58024D.2010402@rock-chips.com>
Date: Fri, 12 Jan 2018 08:33:17 +0800
From: JeffyChen <jeffy.chen@rock-chips.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0
MIME-Version: 1.0
To: Robin Murphy <robin.murphy@arm.com>, linux-kernel@vger.kernel.org
CC: jcliang@chromium.org, tfiga@chromium.org,
        Heiko Stuebner <heiko@sntech.de>,
        linux-rockchip@lists.infradead.org,
        iommu@lists.linux-foundation.org, Joerg Roedel <joro@8bytes.org>,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/9] iommu/rockchip: Fix error handling in attach
References: <20180111082229.24011-1-jeffy.chen@rock-chips.com> <20180111082229.24011-3-jeffy.chen@rock-chips.com> <427ecf29-2024-b746-c567-903c1ce02e75@arm.com>
In-Reply-To: <427ecf29-2024-b746-c567-903c1ce02e75@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

Hi Robin,

thanks for your reply.

On 01/11/2018 11:47 PM, Robin Murphy wrote:
>>
>> +    for (i = 0; i < iommu->num_irq; i++) {
>> +        ret = devm_request_irq(iommu->dev, iommu->irq[i], rk_iommu_irq,
>> +                       IRQF_SHARED, dev_name(dev), iommu);
>
> Why aren't we simply requesting the IRQ once in rk_iommu_probe()? Given
> that the hardware doesn't handle multiple translation contexts, there
> doesn't seem to be much point in being this dynamic about it.
>
it make sense, will do it in next version:)
> Robin.