Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933480AbeALBeO (ORCPT + 1 other); Thu, 11 Jan 2018 20:34:14 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36931 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932471AbeALBeM (ORCPT ); Thu, 11 Jan 2018 20:34:12 -0500 X-Google-Smtp-Source: ACJfBosxJA+dg7Z/JfJAbLiKoVFGpod6bYz25/fYFtFRq6eplA06X92Mknxv4OkSmKW2ewhYAr64+w== Date: Fri, 12 Jan 2018 10:34:08 +0900 From: Sergey Senozhatsky To: Jesper Nilsson Cc: Sergey Senozhatsky , Mikael Starvik , Jesper Nilsson , Fenghua Yu , linux-cris-kernel@axis.com, linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH] cris: Fix conflicting types for _etext, _edata, _end Message-ID: <20180112013408.GA6419@jagdpanzerIV> References: <20180105024744.17037-1-sergey.senozhatsky@gmail.com> <20180111141251.GA754@tigerII.localdomain> <20180111142423.GA32368@axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180111142423.GA32368@axis.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On (01/11/18 15:24), Jesper Nilsson wrote: > On Thu, Jan 11, 2018 at 11:12:51PM +0900, Sergey Senozhatsky wrote: > > On (01/05/18 11:47), Sergey Senozhatsky wrote: > > > Include asm/sections.h header which contains the correct > > > types for _etext, _edata and _end - char arrays. > > > > > > Signed-off-by: Sergey Senozhatsky > > > > Mikael, Jesper, > > > > any opinions? > > This looks sane, and I can take it in the CRIS tree, > allthough I'm currently pondering the future of the CRIS port, > lack of time and active hardware are increasing problems. ah, got it... didn't know that. we have a number of patches in linux-next which introduce some changes to commonly used header files and we saw build errors on other platforms because of conflicting etext/etc types. so I just grepped arch/ and applied the same fix to CRIS. -ss