MIME-Version: 1.0
In-Reply-To: <20180109120311.27565-5-pbonzini@redhat.com>
References: <20180109120311.27565-1-pbonzini@redhat.com> <20180109120311.27565-5-pbonzini@redhat.com>
From: Wanpeng Li <kernellwp@gmail.com>
Date: Fri, 12 Jan 2018 09:49:58 +0800
Message-ID: <CANRm+Cwu+6TkA-dZaCJnMRY4PYMJ8JjQgegMPM8e6UqqJ+9Ohw@mail.gmail.com>
Subject: Re: [PATCH 4/8] kvm: vmx: Set IBPB when running a different VCPU
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm <kvm@vger.kernel.org>,
        Radim Krcmar <rkrcmar@redhat.com>,
        Liran Alon <liran.alon@oracle.com>,
        Jim Mattson <jmattson@google.com>,
        Anthony Liguori <aliguori@amazon.com>, thomas.lendacky@amd.com,
        dwmw@amazon.co.uk, Borislav Petkov <bp@alien8.de>,
        "the arch/x86 maintainers" <x86@kernel.org>,
        Tim Chen <tim.c.chen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org

2018-01-09 20:03 GMT+08:00 Paolo Bonzini <pbonzini@redhat.com>:
>
>         if (!already_loaded) {
> @@ -4029,6 +4031,13 @@ static void free_loaded_vmcs(struct loaded_vmcs *loaded_vmcs)
>         free_vmcs(loaded_vmcs->vmcs);
>         loaded_vmcs->vmcs = NULL;
>         WARN_ON(loaded_vmcs->shadow_vmcs != NULL);
> +
> +       /*
> +        * The VMCS could be recycled, causing a false negative in
> +        * vmx_vcpu_load; block speculative execution.
> +        */
> +       if (have_spec_ctrl)
> +               wrmsrl(MSR_IA32_PRED_CMD, PRED_CMD_IBPB);
>  }

Intel guys told us the recycle is about the address of vmcs, not the
content. Could you explain more why it matters?

Regards,
Wanpeng Li