Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933170AbeALBwe (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Thu, 11 Jan 2018 20:52:34 -0500
Received: from mga14.intel.com ([192.55.52.115]:21626 "EHLO mga14.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932478AbeALBwc (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 11 Jan 2018 20:52:32 -0500
X-Amp-Result: UNKNOWN
X-Amp-Original-Verdict: FILE UNKNOWN
X-Amp-File-Uploaded: False
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,347,1511856000"; 
   d="scan'208";a="20959723"
Date: Thu, 11 Jan 2018 17:52:31 -0800
From: "Raj, Ashok" <ashok.raj@intel.com>
To: Andy Lutomirski <luto@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Tim Chen <tim.c.chen@linux.intel.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Greg KH <gregkh@linuxfoundation.org>,
        Dave Hansen <dave.hansen@intel.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Andi Kleen <ak@linux.intel.com>,
        Arjan Van De Ven <arjan.van.de.ven@intel.com>,
        David Woodhouse <dwmw@amazon.co.uk>,
        Peter Zijlstra <peterz@infradead.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Jun Nakajima <jun.nakajima@intel.com>,
        Asit Mallick <asit.k.mallick@intel.com>, ashok.raj@intel.com
Subject: Re: [PATCH 1/5] x86/ibrs: Introduce native_rdmsrl, and native_wrmsrl
Message-ID: <20180112015231.GA44418@otc-nc-03>
References: <1515720739-43819-1-git-send-email-ashok.raj@intel.com>
 <1515720739-43819-2-git-send-email-ashok.raj@intel.com>
 <CALCETrWy_bTMrkcJfmPu=5dmRnSmKYCDp3+62CPgP1BKiV6U2g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALCETrWy_bTMrkcJfmPu=5dmRnSmKYCDp3+62CPgP1BKiV6U2g@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Thu, Jan 11, 2018 at 05:41:34PM -0800, Andy Lutomirski wrote:
> On Thu, Jan 11, 2018 at 5:32 PM, Ashok Raj <ashok.raj@intel.com> wrote:
> > - Remove including microcode.h, and use native macros from asm/msr.h
> > - added license header for spec_ctrl.c
> >
> > Signed-off-by: Ashok Raj <ashok.raj@intel.com>

[snip]
> > +static inline u64 native_rdmsrl(unsigned int msr)
> > +{
> > +       u64 val;
> > +
> > +       val = __rdmsr(msr);
> > +
> > +       return val;
> > +}
> 
> What's wrong with native_read_msr()?

Yes, i think i should have added to msr.h. The names didn't read as a
pair, one was native_read_msr, wrmsrl could be taken over when paravirt is
defined? 

> 
> > +
> > +static inline void native_wrmsrl(unsigned int msr, u64 val)
> > +{
> > +       __wrmsr(msr, (u32) (val & 0xffffffffULL), (u32) (val >> 32));
> > +}
> 
> What's wrong with just wrmsrl()?  If you really need a native helper
> like this, please add it to arch/x86/asm/msr.h.

I should have done that.. will move these to msr.h instead.

Cheers,
Ashok