Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932988AbeALCIF (ORCPT + 1 other); Thu, 11 Jan 2018 21:08:05 -0500 Received: from mail-lf0-f65.google.com ([209.85.215.65]:38690 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932699AbeALCIB (ORCPT ); Thu, 11 Jan 2018 21:08:01 -0500 X-Google-Smtp-Source: ACJfBovEnpOvxSXj7qZzkA6knFp9vv49MMPNBDydHIMKN6hNgI1FCPl4DkQxl7hw4/7jM5UY3QyJEw== Date: Thu, 11 Jan 2018 18:00:22 -0800 From: Olof Johansson To: Chunfeng Yun Cc: Arnd Bergmann , Matthias Brugger , arm@kernel.org, Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Daniel Kurtz , Andrew-sh Cheng , Chaotian Jing , "dawei.chien@mediatek.com" , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: add #cooling-cells to CPU nodes Message-ID: <20180112020022.t4sw7ga7np2mntq7@localhost> References: <20180110210706.2331225-1-arnd@arndb.de> <1515631110.19513.5.camel@mhfsdcap03> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1515631110.19513.5.camel@mhfsdcap03> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Thu, Jan 11, 2018 at 08:38:30AM +0800, Chunfeng Yun wrote: > On Wed, 2018-01-10 at 22:06 +0100, Arnd Bergmann wrote: > > dtc complains about the lack of #coolin-cells properties for the > > CPU nodes that are referred to as "cooling-device": > > > > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: Warning (cooling_device_property): Missing property '#cooling-cells' in node /cpus/cpu@0 or bad phandle (referred from /thermal-zones/cpu_thermal/cooling-maps/map@0:cooling-device[0]) > > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: Warning (cooling_device_property): Missing property '#cooling-cells' in node /cpus/cpu@100 or bad phandle (referred from /thermal-zones/cpu_thermal/cooling-maps/map@1:cooling-device[0]) > > > > Apparently this property must be '<2>' to match the binding. > > > > Signed-off-by: Arnd Bergmann > > --- > > If this looks ok, I'd apply it directly to the fixes branch > > for 4.15, as the warning is one that was introduced in this > > release. Actually, it's in next/dt (or at least this patch doesn't apply as it is to fixes), so I've added it there. -Olof